[OpenJDK 2D-Dev] RFR 8078654: CloseTTFontFileFunc callback should be removed

Andrew Dinn adinn at redhat.com
Mon Apr 27 10:07:07 UTC 2015


Please review this proposed patch to remove a redundant callback in the
truetype native scaler code. The urgency for this removal comes from the
fact that the callback occasionally falls foul of a race condition which
leads to an NPE:

  http://cr.openjdk.java.net/~adinn/8078654/webrev.00/

The problematic code is the same in JDK9, JDK8 and JDK7.

Previous discussion with Phil Race (tentatively) confirmed that the
removed callback is redundant:

  http://mail.openjdk.java.net/pipermail/2d-dev/2015-January/005015.html

Red Hat support staff subsequently identified the race condition:

  http://mail.openjdk.java.net/pipermail/2d-dev/2015-April/005257.html

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
(USA), Michael O'Neill (Ireland)



More information about the 2d-dev mailing list