[OpenJDK 2D-Dev] RFR(S): 8145077: AIX: fix harfbuzz support

[Volker Simonis]

Hi Phil,

thanks for the review!

Maybe I was unclear, but Behdad already integrated the exact patch upstream:

https://github.com/behdad/harfbuzz/commit/70b33edae7c8b9c031b83c95f00cb383789f1041
https://github.com/behdad/harfbuzz/commit/49e72634af74a9fbad01f42f48e104218413acc0

I'm not aware of any AIX specific label. We only have AIX as selection
in the OS section.

Regards,
Volker


On Thu, Dec 10, 2015 at 7:59 PM, Phil Race <philip.race at oracle.com> wrote:
>
> Should the compiler check go upstream too ?
> It is likely to get lost if it does not.
> Otherwise looks good. I've added noreg-other to the bug.
> Is there an "aix" label in use ?
>
> -phil.
>
>
> On 12/10/2015 09:38 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> here's a slightly updated version of my webrev which is now identical
>> to the version which has just been checked-in into the HarfBuzz
>> upstream repository (thanks to Behdad):
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8145077.v1
>>
>> Except some whitespace changes, the only real difference is that the
>> AIX atomic intrinsics are now additionally guarded by a compiler check
>> which ensures that they only get compiled with IBM's xlC compiler.
>>
>> Regards,
>> Volker
>>
>>
>> On Thu, Dec 10, 2015 at 2:13 PM, Volker Simonis
>> <volker.simonis at gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> could somebody please review this AIX-only fix which adds the harfbuzz
>>> atomic primitives for AIX:
>>>
>>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8145077/
>>> https://bugs.openjdk.java.net/browse/JDK-8145077
>>>
>>> I plan to also submit this patch upstream to the harfbuzz project to
>>> minimize the diffs between the upstream and the OpenJDK version.
>>>
>>> Notice that although this is a client patch I plan to push this
>>> directly to jdk9-dev because it fixes a build failure and I don't want
>>> to wait for the next round-trip trough jdk9-client.
>>>
>>> Thank you and best regards,
>>> Volker
>
>