[OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Dec 15 15:22:58 UTC 2015


Looks fine to me. Thanks.

On 12/12/15 19:17, Laurent Bourgès wrote:
> Sergey,
>
> Here is my latest webrev:
> http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.3/
>
> One more reviewer, please ?
>
>
>> Probably it can be made local to the write method, but this version looks fine too.
>
>     You're right. I will improve that, I did it too quickly.
>
> Fixed: it is clearer and simpler.
>
> Regards,
> Laurent


-- 
Best regards, Sergey.



More information about the 2d-dev mailing list