[OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size
Phil Race
philip.race at oracle.com
Wed Dec 16 22:31:35 UTC 2015
Looks good. I will push it shortly.
-phil.
On 12/15/2015 07:25 AM, Laurent Bourgès wrote:
> Sergey,
>
> thanks for your review.
>
> Could you or Phil push it for me once another reviewer is OK ?
>
> Laurent
>
>
> 2015-12-15 16:22 GMT+01:00 Sergey Bylokhov <Sergey.Bylokhov at oracle.com
> <mailto:Sergey.Bylokhov at oracle.com>>:
>
> Looks fine to me. Thanks.
>
>
> On 12/12/15 19:17, Laurent Bourgès wrote:
>
> Sergey,
>
> Here is my latest webrev:
> http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.3/
> <http://cr.openjdk.java.net/%7Elbourges/png/PNGWriter-6488522.3/>
>
> One more reviewer, please ?
>
>
> Probably it can be made local to the write method, but
> this version looks fine too.
>
>
> You're right. I will improve that, I did it too quickly.
>
> Fixed: it is clearer and simpler.
>
> Regards,
> Laurent
>
>
>
> --
> Best regards, Sergey.
>
>
>
>
> --
> --
> Laurent Bourgès
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20151216/bc8d0ee6/attachment.html>
More information about the 2d-dev
mailing list