[OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

Roman Kennke rkennke at redhat.com
Thu Feb 19 17:59:35 UTC 2015


Am Donnerstag, den 05.02.2015 um 19:52 +0300 schrieb Sergey Bylokhov:
> Hello, Roman, Phil.
> The fix looks fine except an absent documentation in new class and 
> InternalError + 80 chars per line.

I added a class comment. I added a small msg to the internal error
explaining why it happens (what else can I do there? I don't have/want a
fallback on that path). I also fixed the 80chars/line.

http://cr.openjdk.java.net/~rkennke/refactor-x11fm/webrev.02/

Is it ok now to push?

Regards,
Roman






More information about the 2d-dev mailing list