[OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

[Phil Race]

On 2/19/15 8:50 PM, Mandy Chung wrote:
>
> On 2/19/2015 4:23 PM, Phil Race wrote:
>> http://cr.openjdk.java.net/~prr/8035302/
>
> I'll let Sherman and others to do the detailed review here.  Minor 
> comment:
>
> FontDescriptor.java
>    line 56-58: can use try-with-resource.

Its a ByteArrayInputStream there is no leak potential
>    line 62: should it throw UncheckedIOException?

Completely theoretical as far as I can tell.

>
>>
>> With this change, for the benefit of jigsaw, the Charset support 
>> needed by the font code
>> now uses just the public APIs. 
>
> java.desktop to the internal of charsets is an undesirable edge in the 
> module graph [1].  Thank you for eliminating it.  It's not ideal to 
> copy sun.nio code while some day these sun.awt.motif.** will no longer 
> be needed and can be removed.
>
> With this dependency removed,  <top-repo>/modules.xml needs to be 
> updated.  Here is the patch:

I wondered who would do this but if you want it part of this patch, no 
problem I can include it.

-phil.
>
> diff --git a/modules.xml b/modules.xml
> --- a/modules.xml
> +++ b/modules.xml
> @@ -294,7 +294,6 @@
>      </export>
>      <export>
>        <name>sun.nio.cs</name>
> -      <to>java.desktop</to>
>        <to>jdk.charsets</to>
>      </export>
>      <export>
> @@ -602,7 +601,6 @@
>      <depend>java.prefs</depend>
>      <depend re-exports="true">java.xml</depend>
>      <depend re-exports="true">java.datatransfer</depend>
> -    <depend>jdk.charsets</depend>
>      <export>
>        <name>java.applet</name>
>      </export>
> @@ -1481,10 +1479,6 @@
>    <module>
>      <name>jdk.charsets</name>
>      <depend>java.base</depend>
> -    <export>
> -      <name>sun.nio.cs.ext</name>
> -      <to>java.desktop</to>
> -    </export>
>    </module>
>    <module>
>      <name>jdk.compiler</name>
>
> Run make verify-modules to verify the dependencis or make images will 
> do it too.
>
> Mandy
> [1] http://openjdk.java.net/jeps/200
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20150219/a3a3d6b4/attachment.html>