[OpenJDK 2D-Dev] Review Request: (JDK-8048782) OpenJDK: PiscesCache : xmax/ymax rounding up can cause RasterFormatException.

[Phil Race]

Hi,

The fix seems fine but the test needs to be amended
- it doesn't have the GPL header.
- we do NOT use @author tags in openjdk. There was actually an intent to 
remove
  them from source files opportunistically.
- the indendation is all wrong and does not follow our style guidelines

http://www.oracle.com/technetwork/java/codeconvtoc-136057.html

Yes, that page is old but we still follow it.

Also I am sure this would be reproducible with Oracle JDK too if you passed
-Dsun.java2d.renderer=sun.java2d.pisces.PiscesRenderingEngine


-phil.

On 02/19/2015 08:39 PM, prasanta sadhukhan wrote:
> Hi,
>
> I would like a review for a solution of this bug.
> In OpenJDK9, "java.awt.image.RasterFormatException: (x + width) is 
> outside raster" is thrown when the bounding box width outgrows 
> original raster. This is because PiscesRenderingEngine does not take 
> care of clipping the bounding box correctly.
>
> Bug:https://bugs.openjdk.java.net/browse/JDK-8048782
> webrev: http://cr.openjdk.java.net/~serb/prasanta/8048782/webrev.00
>
> Regards
> Prasanta