[OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

[Sergey Bylokhov]

> We usually don't have fontconfig on AIX and it would be nice if AWT
> would still work even without fontconfig. There are also other ancient
> operating systems without fontconfig like for example HP UX which are
> not currently supported by OpenJDK but by commercial licensees of the
> OpenJDK source base.
This means that Caciocavallo  will not work on AIX. Roman, is it expected?
>
> Regards,
> Volker
>
> On Thu, Feb 5, 2015 at 6:01 PM, Phil Race <philip.race at oracle.com> wrote:
>> It should still be functional. Some day we are likely to remove it but not
>> yet.
>> In the event that we can't find fontconfig for some reason, this should
>> allow us to limp along moderately well as opposed to being in dire straits.
>>
>> -phil.
>>
>>
>> On 2/5/15 8:52 AM, Sergey Bylokhov wrote:
>>> Hello, Roman, Phil.
>>> The fix looks fine except an absent documentation in new class and
>>> InternalError + 80 chars per line.
>>> But I have a question: do we really need this failback?
>>>
>>>   527       /* Using the X11 font path to locate font files is now a
>>> fallback
>>>   528        * useful only if fontconfig failed, or is incomplete. So we
>>> could
>>>   529        * remove this code completely and the consequences should be
>>> rare
>>>   530        * and non-fatal. If this happens, then the calling Java code
>>> can
>>>   531        * be modified to no longer require that the AWT lock (the
>>> X11GE)
>>>   532        * be initialised prior to calling this code.
>>>   533        */
>>>
>>>
>>>
>>> On 04.02.2015 12:33, Roman Kennke wrote:
>>>>>> http://mail.openjdk.java.net/pipermail/awt-dev/2015-January/008819.html
>>>>>>
>>>>>> I got no reply, so I'm sending it here, maybe it's a better fit? ;-)
>>>>> font related discussions should go to 2d-dev.
>>>>> The change looks OK. But test it as much as
>>>>> you can. The previous re-factoring in JDK7
>>>>> had a fairly long bug trail.
>>>> Ok. I tested a couple of applications, including Java2Demo, Font2DTest
>>>> and some more. They all work fine for me.
>>>>
>>>>> - Do submit a bug and mark it noreg-cleanup
>>>> Done:
>>>> https://bugs.openjdk.java.net/browse/JDK-8072436
>>>>
>>>>> - Do get a 2nd reviewer before committing.
>>>> How do I do that? That seems to be the tricky part.. ;-)
>>>>
>>>>> - Do update the (C) in the new file to 2015 since the clock ticked
>>>>> since you first sent the review.
>>>> Done:
>>>>
>>>> http://cr.openjdk.java.net/~rkennke/refactor-x11fm/webrev.01/
>>>>
>>>> I only updated the (C) of the new file, can I leave the existing
>>>> copyrights alone?
>>>>
>>>> Thanks & best regards,
>>>> Roman
>>>>
>>>>> -phil.
>>>>>
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> I am currently working on a port of AWT/Java2D to DirectFB (using
>>>>>> Caciocavallo [1] as a porting layer).
>>>>>>
>>>>>> I hit one obstacle that is the X11FontManager. I want to use fontconfig
>>>>>> to work with fonts, but can't use anything X11.
>>>>>>
>>>>>> I refactored X11FontManager and related classes and native code to
>>>>>> avoid
>>>>>> calling anything X11 specific. Basically I created a superclass of
>>>>>> X11FontManager called FcFontManager that does all the fontconfig
>>>>>> related
>>>>>> stuff, and use that in my backend. The changes should not affect the
>>>>>> X11
>>>>>> implementation.
>>>>>>
>>>>>> Can you please review the changes here:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~rkennke/refactor-x11fm/webrev.00/
>>>>>>
>>>>>> I would like to push this into jdk9-client if you think it's ok.
>>>>>>
>>>>>> Best regards,
>>>>>> Roman
>>>>>>
>>>>>> [1] http://openjdk.java.net/projects/caciocavallo/
>>>>>>
>>>>>>
>>>>>>
>>>


-- 
Best regards, Sergey.