[OpenJDK 2D-Dev] [9] request for review: 8098853: [PIT] Fonts look much darker than before in the PIT build for b68

[Phil Race]

Andrew,

How did you choose 165 as the OS X default value ?
Was it through experimentation or was there some documentation?
On other platforms we read the value from system settings.
Can we find this information on OS X ?


-phil.

On 07/15/2015 07:32 AM, Andrew Brygin wrote:
> Hello,
>
>  could you please review a fix for 8098853?
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8098853
> webrev: http://cr.openjdk.java.net/~bae/8098853/9/webrev.00/
>
>  By default, we use 140 as lcd contrast value. However, on macosx
>  this value causes significant discrepancy with results of native
>  text rendering. Although perfect match is not achievable at the
>  moment, the lcd contrast 165 provides a bit better approximation
>  of the native text.
>
>  Let's consider to introduce a mean to adjust the lcd contrast in
>  swing applications. We have a set of font rendering hints (desktop
>  font hints), so let's populate this set with the TEXT_LCD_CONTRAST
>  hint. 165 is default value for macosx, and it can be adjusted using
>  property "sun.toolkit.fontSmoothingContrast".
>
>  Please take a look.
>
> Thanks,
> Andrew