[OpenJDK 2D-Dev] RFR: 8u-dev backport: 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

[Phil Race]

Sigh ..

I use xcode 4.x still for building JDK 9 - and it appears I have run 
into this
and you can't disable it as I can a warning.

I filed https://bugs.openjdk.java.net/browse/JDK-8081886

can someone review the fix here :

diff --git 
a/src/java.desktop/macosx/native/libawt_lwawt/font/CGGlyphImages.m 
b/src/java.desktop/macosx/native/libawt_lwawt/font/CGGlyphImages.m
--- a/src/java.desktop/macosx/native/libawt_lwawt/font/CGGlyphImages.m
+++ b/src/java.desktop/macosx/native/libawt_lwawt/font/CGGlyphImages.m
@@ -203,6 +203,7 @@
      if (reverseGamma == 0) {
          // initialize gamma lut
          double gamma;
+        int i;
          const char* pGammaEnv = getenv("J2D_LCD_REVERSE_GAMMA");
          if (pGammaEnv != NULL) {
              reverseGamma = atol(pGammaEnv);
@@ -213,7 +214,7 @@
          }

          gamma = 100.0 / reverseGamma;
-        for (int i = 0; i < 256; i++) {
+        for (i = 0; i < 256; i++) {
              double x = ((double)i) / 255.0;
              reverseGammaLut[i] = (UInt8)(255 * pow(x, gamma));
          }

-phil.

On 6/1/15 3:45 PM, Phil Race wrote:
> This is fine by me.
>
> -phil.
>
> On 05/30/2015 10:21 AM, Andrew Brygin wrote:
>> Hello Sergey, and Phil,
>>
>>  could you please review a backport of the fix for 8023794
>>  to 8u-dev?
>>
>>  The change is exactly same, except a declaration of the loop counter 
>> 'i'
>>  in getReverseGammaLut() routine (CGGlyphImages.m, lines 206-217):
>>  it has to be moved in order to meet XCode 4.x expectations.
>>
>>  http://cr.openjdk.java.net/~bae/8023794/8u-dev/webrev.00/
>>
>> Please take a look.
>>
>> Thanks,
>> Andrew.
>>
>