[OpenJDK 2D-Dev] Review Request JDK-8129457: Disposer.pollRemove may fail to dispose
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Mon Jun 29 09:09:51 UTC 2015
HI, Prasanta.
The fix looks fine, but is it possible to write a test for it?
On 29.06.15 9:46, prasanta sadhukhan wrote:
> Gentle reminder for review of this small fix.
>
> Regards
> Prasanta
> On 6/24/2015 2:34 PM, prasanta sadhukhan wrote:
>> Hi,
>>
>> Please review a small fix for this issue where it seems if polling is
>> performed before the bounds are checked then it may happen that "obj"
>> maybe removed from queue without getting disposed if the bounds
>> checks are exceeded. Fix is to check for bounds before polling the
>> queue to remove the object so that we can bail out if bounds are
>> exceeded before obj is removed from queue.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8129457
>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8129457/webrev.00/
>>
>> Regards
>> Prasanta
>
--
Best regards, Sergey.
More information about the 2d-dev
mailing list