[OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

Mandy Chung mandy.chung at oracle.com
Fri Mar 20 03:19:47 UTC 2015


On 03/16/2015 02:32 PM, Phil Race wrote:
>> Here is an updated fix that instead of removing the sun.nio 
>> dependency instead removes the jdk.charsets static dependency. From 
>> the internal API point of view its sun.nio.cs.ext that is the issue, 
>> not sun.nio
>>
>> http://cr.openjdk.java.net/~prr/8035302.1/
>>

Looks quite good and much cleaner.

src/jdk.charsets/unix/classes/sun/nio/cs/ext/CompoundTextSupport.java

    cls = Class.forName("sun.awt.motif." + enc);

Should we do something about this Class.forName?

modules.xml - you can take out <depend>jdk.charsets</depend>
from java.desktop module.  You can verify the module access
by make verify-modules target.

There are tests referencing sun.awt.motif that I assume you will
update and send out another webrev?

Tests under test/java/awt are expected and surprisingly there are
tests in test/sun/nio/cs:

test/sun/nio/cs/TestX11CNS.java
test/sun/nio/cs/TestX11JIS0201.java

thank you for doing this.
Mandy




More information about the 2d-dev mailing list