[OpenJDK 2D-Dev] [9] RFR JDK-8067059, , PrinterJob.pageDialog() with DialogSelectionType.NATIVE returns a PageFormat when cancelled.

[Philip Race]

Shouldn't this use reference equality ?
Also the test does a number of wild card imports instead of
the specific classes it needs. And I am not sure why it
is importing java.awt.* anyway ..

And I find qualifying "java.lang.String" to be unnecessary.

-phil.

On 11/3/15, 12:59 AM, prasanta sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8067059
> webrev: http://cr.openjdk.java.net/~psadhukhan/8067059/webrev.00/
>
> The issue was if we "cancel" Printer Job setup dialog which has been 
> created with DialogSelectionType.NATIVE
> it should return "null" as per spec
> https://docs.oracle.com/javase/8/docs/api/java/awt/print/PrinterJob.html#pageDialog-javax.print.attribute.PrintRequestAttributeSet-
> /[If the user cancels the dialog, the attributes will not reflect any 
> changes made by the user, and the return value will be null.]
>
> /We were returning PageFormat instead. Fixed to return null in such case.
>
> Regards
> Prasanta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20151112/c93e947f/attachment.html>