[OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

[Phil Race]

Approved.

-phil.

On 11/23/2015 01:39 AM, Jayathirth D V wrote:
>
> Hello All,
>
> Changed test image used in previous webrev. Because I need image with 
> similar properties in another fix(JDK - 8041501) but content should be 
> white.
>
> Changed image and its name in test file no other code changes.
>
> _Updated Webrev: _
>
> __
>
> http://cr.openjdk.java.net/~rchamyal/jay/8074967/webrev.01/ 
> <http://cr.openjdk.java.net/%7Erchamyal/jay/8074967/webrev.01/>
>
> Please review.
>
> Thanks,
>
> Jay
>
> *From:*Jayathirth D V
> *Sent:* Thursday, November 19, 2015 3:19 PM
> *To:* Philip Race; Prasanta Sadhukhan; 2d-dev at openjdk.java.net
> *Subject:* <OpenJDK 2D-Dev> Review request for JDK-8074967: 
> JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard 
> metadata
>
> Hi Phil/Prasanta,
>
> _Please review following fix in jdk9:_
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8074967
>
> Webrev : http://cr.openjdk.java.net/~rchamyal/jay/8074967/webrev.00/ 
> <http://cr.openjdk.java.net/%7Erchamyal/jay/8074967/webrev.00/>
>
> Bug : JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in 
> standard metadata
>
> Root cause : In JPEG image if there is no JFIF or EXIF header. We are 
> not checking component ID's to determine color space properly. Third 
> channel component ID (3) is matching the length of componentSpecs 
> length and we are not setting colorspace as YCbCr. It is set to RGB 
> which is wrong.
>
> Solution : We should check for id greater than componentSpecs length 
> and not greater than equal. But adding a tighter check to match 
> individual component ID is better. So made changes to match individual 
> component ID with 1, 2 & 3 to set color space as YCbCr.
>
> Thanks,
>
> Jay
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20151123/2d9ac030/attachment.html>