[OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

[Alexander Scherbatiy]

On 9/23/2015 6:05 PM, Sergey Bylokhov wrote:
> Hi, Alexander.
> A few comments:
>  - Can you clarify the updated array in BufferedImageGraphicsConfig? 
> Probably some javadoc will be useful?
    The BufferedImageGraphicsConfig caches configs with some types. 
Configs with the same type but  different scales should be treated as 
different configs.
    The fix caches configs with scales 1 in the first index of the array 
and others in the second.

>  - It it possible to document the new options somewhere? I recall we 
> have description of some of related options. Also I suggest to file an 
> additional issue to make these options crossplatform.
    Scaling options scale the size of a window on Windows and Linux but 
do not scale it on Mac OS.
    If it makes sense I will add the same  "sun.java2d.uiScale" option 
to these three platforms.

    Thanks,
    Alexandr.
>
>
> On 22.09.15 12:33, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>    bug: https://bugs.openjdk.java.net/browse/JDK-8073320
>>    webrev: http://cr.openjdk.java.net/~alexsch/8073320/webrev.00
>>
>>    This is an initial part of the HiDPI Graphics support on Windows for
>> the JEP 263: HiDPI Graphics on Windows and Linux
>>      http://openjdk.java.net/jeps/263
>>
>>    - scale factors are added to surface dates
>>    - window size, events coordinates and font are scaled on native side
>>    - backup buffered image is scaled in SunVolatileImage
>>    - AwtRobot MouseMove() and GetRGBPixels() methods are updated
>>    - GetDpiForMonitor function is used to query the specified monitor
>> for the horizontal and vertical DPI values.
>>      If it is not available ID2D1Factory::GetDesktopDpi method is used
>> instead.
>>    - "sun.java2d.uiScale.enabled", "sun.java2d.win.uiScale",
>> "sun.java2d.win.uiScaleX", and "sun.java2d.win.uiScaleY" options are
>> added for the testing purposes.
>>
>> Thanks,
>> Alexandr.
>>
>
>