[OpenJDK 2D-Dev] [9] RFR JDK-8072682: getBounds call on graphics.getDeviceConfiguration() returning cached information

prasanta sadhukhan prasanta.sadhukhan at oracle.com
Mon Oct 12 05:59:43 UTC 2015


Thanks for the review.
I have removed the unused fields.
Here's the modified webrev:
http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.01/

Hi Sergey, can you commit this fix?

Regards
Prasanta
On 10/10/2015 2:02 AM, Jim Graham wrote:
> +1 for the fix and removing the fields.
>
>         ...jim
>
> On 10/9/15 8:37 AM, Sergey Bylokhov wrote:
>> Hi, Prasanta.
>> It seems that width&height fields are not used after the fix and can be
>> removed.
>>
>> On 08.10.15 11:12, prasanta sadhukhan wrote:
>>> Hi All,
>>>
>>> Please review a fix for jdk9
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8072682
>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.00/
>>>
>>> BufferedImageGraphicsConfig creates a cache to store the BufferedImage
>>> information but it was found that the cache shares the
>>> GraphicsConfiguration across images of the same type,
>>> so for different images of same type, the first stored information is
>>> returned when getBounds() is queried.
>>> The consensus is instead of adding image bounds info to the cache, let
>>> the deviceConfig.getBounds() returns the MAXINT bounds.
>>>
>>> Regards
>>> Prasanta
>>>
>>
>>




More information about the 2d-dev mailing list