[OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

[Sergey Bylokhov]

Hi, Jay.
I suggest to check correct/expected result in the test instead of 
previous incorrect zero.

Previously I forgot to mention, that it will be good to name the test by 
some useful name instead of some bug number(see examples in 
javax/imageio/plugins).

On 13.10.15 11:12, Jayathirth D V wrote:
> Hello All,
>
> Removed Trailing whitespace present in code.
>
> Please find updated webrev link:
>
> http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.02/
>
> Thanks,
>
> Jay
>
> *From:* Jayathirth D V
> *Sent:* Monday, October 12, 2015 2:15 PM
> *To:* 2d-dev at openjdk.java.net; Philip Race; Sergey Bylokhov
> *Subject:* [OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for
> JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
>
> Hello All,
>
> Made small change on how we need to represent floating point constant in
> Java(1000.0 -> 1000.0F).
>
> Please find updated Webrev link:
>
> Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.01/
>
> Please review.
>
> Thanks,
>
> Jay
>
> *From:* Jayathirth D V
> *Sent:* Thursday, October 08, 2015 2:20 PM
> *To:* 2d-dev at openjdk.java.net <mailto:2d-dev at openjdk.java.net>; Philip
> Race; Sergey Bylokhov
> *Subject:* [OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for
> JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
>
> Hello All,
>
> Please review following fix in jdk9:
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-7182758
>
> Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.00/
>
> Bug : BMPMetadata returns invalid PhysicalPixelSpacing
>
> Root cause : Whenever XPixelsPerMter or YPixelsPerMeter is more than
> value 1 in BMP header. Horizontal & Vertical Physical pixel spacing were
> returned as zero.
>
>                            In getStandardDimensionNode() method of
> BMPMetadata.java we are dividing 1 by XPixelsPerMter/ YPixelsPerMter. When
>
>                            XPixelsPerMter/ YPixelsPerMter is more than
> 1. Resulted value is stored without decimal part, which resulted in zero.
>
> Solution : Made changes to how Horizontal & Vertical Physical pixel
> spacing is calculated so that decimal value is not truncated.
>
> Thanks,
>
> Jay
>


-- 
Best regards, Sergey.