[OpenJDK 2D-Dev] [9] Review request for 8137571 Linux HiDPI Graphics support

[Sergey Bylokhov]

Hi, Alexander.
I see that in a few places you have made a change:
Toolkit.getDefaultToolkit().getScreenSize();
to
getGraphicsConfiguration().getBounds();
My first impression was that you fix some bug related to multi-monitor. 
But it seems because the GC.getBounds() uses correct downscaled bounds, 
and the Toolkit.getScreenSize(); was not updated and uses the real 
screen bounds. I guess toolkit.xx should be updated also.


On 22.10.15 17:03, Alexander Scherbatiy wrote:
> On 10/10/2015 3:16 AM, Jim Graham wrote:
>> Hi Alexandr,
>>
>> Is it possible to create a diff of this without the fixes from 8073320
>> mixed in?  This bug is really just focused on the Linux support of
>> that other framework, right?
>      Here is the webrev which contains only the Linux changes:
>         http://cr.openjdk.java.net/~alexsch/8137571/webrev.01
>
>     Thanks,
>     Alexandr.
>
>>
>>             ...jim
>>
>> On 10/5/15 7:01 AM, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>    bug: https://bugs.openjdk.java.net/browse/JDK-8137571
>>>    webrev: http://cr.openjdk.java.net/~alexsch/8137571/webrev.00
>>>
>>>    This is an initial part of the HiDPI Graphics support on Linux for
>>> the JEP 263: HiDPI Graphics on Windows and Linux
>>>      http://openjdk.java.net/jeps/263
>>>
>>>    - scale factors are added to surface dates
>>>    - window size and events coordinates are scaled on peer side
>>>    - XRobotPeer mouseMove() and getRGBPixel() methods are updated
>>>    - GDK_SCALE system variable is used to detect the scale factor in
>>> GTK+
>>>    - "sun.java2d.uiScale.enabled", and "sun.java2d.uiScale" options are
>>> added for the testing purposes
>>>    - some classes like LWWindowPeer, SurfaceManager, SunGraphics2D,
>>> DrawImage, SurfaceData are just the same as in the fix for HiDPI
>>> Graphics support on Windows
>>>
>>> Thanks,
>>> Alexandr.
>>>
>


-- 
Best regards, Sergey.