From prasanta.sadhukhan at oracle.com Thu Sep 3 06:29:53 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Thu, 3 Sep 2015 11:59:53 +0530 Subject: [OpenJDK 2D-Dev] [9] RFR: JDK-8134476 Broken Hyperlink in JDK 8 java.awt.Font javadocs Message-ID: <55E7E8E1.9050805@oracle.com> Hi, Please review a simple fix to update the Font.java javadoc Bug: https://bugs.openjdk.java.net/browse/JDK-8134476 wevrev: http://cr.openjdk.java.net/~psadhukhan/8134476/webrev.00/ The hyperlink to Physical/Logical font advantage/disadvantage pointing to Internationalization FAQ document is broken. Fix to point to correct link. Regards Prasanta From philip.race at oracle.com Thu Sep 3 06:45:00 2015 From: philip.race at oracle.com (Philip Race) Date: Wed, 02 Sep 2015 23:45:00 -0700 Subject: [OpenJDK 2D-Dev] [9] RFR: JDK-8134476 Broken Hyperlink in JDK 8 java.awt.Font javadocs In-Reply-To: <55E7E8E1.9050805@oracle.com> References: <55E7E8E1.9050805@oracle.com> Message-ID: <55E7EC6C.2000900@oracle.com> Approved. -phil. On 9/2/15, 11:29 PM, prasanta sadhukhan wrote: > Hi, > > Please review a simple fix to update the Font.java javadoc > > Bug: https://bugs.openjdk.java.net/browse/JDK-8134476 > wevrev: http://cr.openjdk.java.net/~psadhukhan/8134476/webrev.00/ > > The hyperlink to Physical/Logical font advantage/disadvantage pointing > to Internationalization FAQ document is broken. > Fix to point to correct link. > > Regards > Prasanta From Sergey.Bylokhov at oracle.com Thu Sep 3 15:04:31 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 3 Sep 2015 18:04:31 +0300 Subject: [OpenJDK 2D-Dev] [9] RFR: JDK-8134476 Broken Hyperlink in JDK 8 java.awt.Font javadocs In-Reply-To: <55E7E8E1.9050805@oracle.com> References: <55E7E8E1.9050805@oracle.com> Message-ID: <55E8617F.2020206@oracle.com> Look fine. On 03.09.15 9:29, prasanta sadhukhan wrote: > Hi, > > Please review a simple fix to update the Font.java javadoc > > Bug: https://bugs.openjdk.java.net/browse/JDK-8134476 > wevrev: http://cr.openjdk.java.net/~psadhukhan/8134476/webrev.00/ > > The hyperlink to Physical/Logical font advantage/disadvantage pointing > to Internationalization FAQ document is broken. > Fix to point to correct link. > > Regards > Prasanta -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Fri Sep 4 12:23:02 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 4 Sep 2015 15:23:02 +0300 Subject: [OpenJDK 2D-Dev] [9] Review Request: 7131835 [TEST_BUG] Test does not consider that the rounded edges of the window in Mac OS 10.7 Message-ID: <55E98D26.1030205@oracle.com> Hello. Please review the fix for jdk9. The updated test does not take into account rounded corners of decorated window, and sometimes overlap with the Dock. The test is moved to the open ws. Bug: https://bugs.openjdk.java.net/browse/JDK-7131835 The new test: http://cr.openjdk.java.net/~serb/7131835/webrev.00 Only useful changes for convenience: http://cr.openjdk.java.net/~serb/7131835/diff -- Best regards, Sergey. From alexander.zvegintsev at oracle.com Fri Sep 4 12:29:11 2015 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Fri, 4 Sep 2015 15:29:11 +0300 Subject: [OpenJDK 2D-Dev] [9] Review Request: 7131835 [TEST_BUG] Test does not consider that the rounded edges of the window in Mac OS 10.7 In-Reply-To: <55E98D26.1030205@oracle.com> References: <55E98D26.1030205@oracle.com> Message-ID: <55E98E97.3060607@oracle.com> looks fine. Thanks, Alexander. On 09/04/2015 03:23 PM, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk9. > The updated test does not take into account rounded corners of > decorated window, and sometimes overlap with the Dock. The test is > moved to the open ws. > > Bug: https://bugs.openjdk.java.net/browse/JDK-7131835 > The new test: http://cr.openjdk.java.net/~serb/7131835/webrev.00 > Only useful changes for convenience: > http://cr.openjdk.java.net/~serb/7131835/diff > From yuri.nesterenko at oracle.com Fri Sep 11 10:43:53 2015 From: yuri.nesterenko at oracle.com (Yuri Nesterenko) Date: Fri, 11 Sep 2015 13:43:53 +0300 Subject: [OpenJDK 2D-Dev] [9] Review Request: 7131835 [TEST_BUG] Test does not consider that the rounded edges of the window in Mac OS 10.7 In-Reply-To: <55E98E97.3060607@oracle.com> References: <55E98D26.1030205@oracle.com> <55E98E97.3060607@oracle.com> Message-ID: <55F2B069.2090602@oracle.com> +1 -yan On 09/04/2015 03:29 PM, Alexander Zvegintsev wrote: > looks fine. > > Thanks, > > Alexander. > > On 09/04/2015 03:23 PM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk9. >> The updated test does not take into account rounded corners of >> decorated window, and sometimes overlap with the Dock. The test is >> moved to the open ws. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-7131835 >> The new test: http://cr.openjdk.java.net/~serb/7131835/webrev.00 >> Only useful changes for convenience: >> http://cr.openjdk.java.net/~serb/7131835/diff >> > From ninghua at linux.vnet.ibm.com Wed Sep 16 05:10:09 2015 From: ninghua at linux.vnet.ibm.com (ninghua at linux.vnet.ibm.com) Date: Wed, 16 Sep 2015 01:10:09 -0400 Subject: [OpenJDK 2D-Dev] Remove redundant package name in src/java.desktop/share/classes/sun/java2d/Disposer.java In-Reply-To: <20150426225647.Horde.qBCMviy7AJfKJgmf397ogA1@ltc.linux.ibm.com> References: <20150426225647.Horde.qBCMviy7AJfKJgmf397ogA1@ltc.linux.ibm.com> Message-ID: <20150916011009.Horde.v2RMZ6sitkHHlir0k1OuVw2@ltc.linux.ibm.com> Is there any progress for the patch? Quoting ninghua at linux.vnet.ibm.com: > A. The problem to be resolve or feature to be added > The class name includes package name java.security/java.lang.ref > though they were already imported > > B. The solution proposed by this patch > Remove package name java.security/java.lang.ref from class name > > C: Modified file > src/java.desktop/share/classes/sun/java2d/Disposer.java > > D:Patch > --- > old/src/java.desktop/share/classes/sun/java2d/Disposer.java 2014-09-02 > 10:04:34.098277541 +0800 > +++ > new/src/java.desktop/share/classes/sun/java2d/Disposer.java 2014-09-02 > 10:04:33.918277545 +0800 > @@ -61,15 +61,15 @@ > public static int refType = PHANTOM; > > static { > - java.security.AccessController.doPrivileged( > - new java.security.PrivilegedAction() { > + AccessController.doPrivileged( > + new PrivilegedAction() { > public Void run() { > System.loadLibrary("awt"); > return null; > } > }); > initIDs(); > - String type = java.security.AccessController.doPrivileged( > + String type = AccessController.doPrivileged( > new > sun.security.action.GetPropertyAction("sun.java2d.reftype")); > if (type != null) { > if (type.equals("weak")) { > @@ -134,7 +134,7 @@ > if (target instanceof DisposerTarget) { > target = ((DisposerTarget)target).getDisposerReferent(); > } > - java.lang.ref.Reference ref; > + Reference ref; > if (refType == PHANTOM) { > ref = new PhantomReference<>(target, queue); > } else { > > It is attached as webrev-OJDK-943-OpenJDK9.zip > > > Regards, > > NingHua From mark.reinhold at oracle.com Thu Sep 17 21:35:00 2015 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 17 Sep 2015 14:35:00 -0700 (PDT) Subject: [OpenJDK 2D-Dev] JEP 262: TIFF Image I/O Message-ID: <20150917213500.E1D6E71DFD@eggemoggin.niobe.net> New JEP Candidate: http://openjdk.java.net/jeps/262 - Mark From mark.reinhold at oracle.com Thu Sep 17 22:11:11 2015 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 17 Sep 2015 15:11:11 -0700 (PDT) Subject: [OpenJDK 2D-Dev] JEP 263: HiDPI Graphics on Windows and Linux Message-ID: <20150917221111.4B6E871E0C@eggemoggin.niobe.net> New JEP Candidate: http://openjdk.java.net/jeps/263 - Mark From prasanta.sadhukhan at oracle.com Fri Sep 18 10:27:22 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Fri, 18 Sep 2015 15:57:22 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8040689 Fonts antialiasing artifacts appear when using translucent composited images Message-ID: <55FBE70A.2010705@oracle.com> Hi All, Please review a fix for a problem where Antialiased font drawn on a translucent bufferedimage creates artifacts. Bug: https://bugs.openjdk.java.net/browse/JDK-8040689 webrev: http://cr.openjdk.java.net/~psadhukhan/8040689/webrev.00/ Antialiased font rendering was done via software loops whose blending maths do not handle AA glyphs on translucent destinations correctly. Since modifying the loop will have impact on other things and since it seems intention was to handle AA font on opaque destination from the comment on AATextRenderer.java //**// // * A delegate pipe of SG2D for drawing anti-aliased text with// // * a solid source colour to an opaque destination.// // */// //public class AATextRenderer extends GlyphListLoopPipe /I have modified//the code to use other text pipeline like XRender in linux or D3D in windows to handle AA font for translucent destinations. Regards Prasanta -------------- next part -------------- An HTML attachment was scrubbed... URL: From philip.race at oracle.com Fri Sep 18 20:00:25 2015 From: philip.race at oracle.com (Phil Race) Date: Fri, 18 Sep 2015 13:00:25 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8133309: Some unicode characters do not display any more after upgrading to Windows 10 Message-ID: <55FC6D59.5030101@oracle.com> https://bugs.openjdk.java.net/browse/JDK-8133309 http://cr.openjdk.java.net/~prr/8133309/ Add Segoe UI Symbol (available on Vista and later) to the fall back list of fonts for Windows. This gives us some coverage we did not have before - better quality too - but is particularly needed on Windows 10. -phil. From james.graham at oracle.com Fri Sep 18 20:13:31 2015 From: james.graham at oracle.com (Jim Graham) Date: Fri, 18 Sep 2015 13:13:31 -0700 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8040689 Fonts antialiasing artifacts appear when using translucent composited images In-Reply-To: <55FBE70A.2010705@oracle.com> References: <55FBE70A.2010705@oracle.com> Message-ID: <55FC706B.9030602@oracle.com> Hi Prasanta, I want Phil to evaluate this as well since we are now using a different and potentially slower or less capable pipeline in what may be a common case. Have you measured the performance difference before and after this change? With respect to the code, please maintain the "{" on the next line style (when coming after a conditional that had a line continuation) that is used throughout this code. Also pare down the test case to not require a GUI and to not create a Frame and not require a call to invokeAndWait(). None of that is necessary... ...jim On 9/18/15 3:27 AM, prasanta sadhukhan wrote: > Hi All, > > Please review a fix for a problem where Antialiased font drawn on a > translucent bufferedimage creates artifacts. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8040689 > webrev: http://cr.openjdk.java.net/~psadhukhan/8040689/webrev.00/ > > Antialiased font rendering was done via software loops whose blending > maths do not handle AA glyphs on translucent destinations correctly. > Since modifying the loop will have impact on other things and since it > seems intention was to handle AA font on opaque destination from the comment > on AATextRenderer.java > //**// > // * A delegate pipe of SG2D for drawing anti-aliased text with// > // * a solid source colour to an opaque destination.// > // */// > //public class AATextRenderer extends GlyphListLoopPipe > > /I have modified//the code to use other text pipeline like XRender in > linux or D3D in windows to handle AA font for translucent destinations. > > Regards > Prasanta From philip.race at oracle.com Fri Sep 18 21:37:28 2015 From: philip.race at oracle.com (Phil Race) Date: Fri, 18 Sep 2015 14:37:28 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop Message-ID: <55FC8418.7060603@oracle.com> http://cr.openjdk.java.net/~prr/8136783/ https://bugs.openjdk.java.net/browse/JDK-8136783 The idea here is to have our sources follow the recommended order fom the JLS which is further documented here https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Modifier.html#toString-int- For background this was applied to core-libs here : http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html The script was checked in here : http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035246.html It was proposed to run it on the rest of the JDK here : http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035273.html What I am updating here is all the files under src/java.desktop which is a decent-sized chunk.: 324 files. I recommend looking at the jdk.patch file I have checked the changes myself visually but also used JPRT to make sure that no introduced syntax error causes a build failure. Separately 2 minor changes to closed source files have been sent for internal review. -phil. From martinrb at google.com Fri Sep 18 21:52:32 2015 From: martinrb at google.com (Martin Buchholz) Date: Fri, 18 Sep 2015 14:52:32 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop In-Reply-To: <55FC8418.7060603@oracle.com> References: <55FC8418.7060603@oracle.com> Message-ID: Looks good to me! On Fri, Sep 18, 2015 at 2:37 PM, Phil Race wrote: > http://cr.openjdk.java.net/~prr/8136783/ > https://bugs.openjdk.java.net/browse/JDK-8136783 > > The idea here is to have our sources follow the > recommended order fom the JLS which is further documented here > > https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Modifier.html#toString-int- > > For background this was applied to core-libs here : > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035217.html > > The script was checked in here : > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035246.html > > It was proposed to run it on the rest of the JDK here : > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035273.html > > What I am updating here is all the files under src/java.desktop which > is a decent-sized chunk.: 324 files. I recommend looking at the jdk.patch > file > > I have checked the changes myself visually but also used JPRT to > make sure that no introduced syntax error causes a build failure. > > Separately 2 minor changes to closed source files have been sent for > internal review. > > -phil. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From Sergey.Bylokhov at oracle.com Sat Sep 19 19:01:28 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Sat, 19 Sep 2015 22:01:28 +0300 Subject: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop In-Reply-To: <55FC8418.7060603@oracle.com> References: <55FC8418.7060603@oracle.com> Message-ID: <55FDB108.80504@oracle.com> Hi, Phil. > > > What I am updating here is all the files under src/java.desktop which > is a decent-sized chunk.: 324 files. I recommend looking at the > jdk.patch file What about src/java.datatransfer module?(it was extracted from desktop) > > I have checked the changes myself visually but also used JPRT to > make sure that no introduced syntax error causes a build failure. > > Separately 2 minor changes to closed source files have been sent for > internal review. > > -phil. -- Best regards, Sergey. From philip.race at oracle.com Sat Sep 19 19:39:31 2015 From: philip.race at oracle.com (Phil Race) Date: Sat, 19 Sep 2015 12:39:31 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop In-Reply-To: <55FDB108.80504@oracle.com> References: <55FC8418.7060603@oracle.com> <55FDB108.80504@oracle.com> Message-ID: Let me do that as separate review. There are also demos and tests do this is not the last of it anyway but this is a big one to get out of the way -Phil. > On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov wrote: > > Hi, Phil. >> >> >> What I am updating here is all the files under src/java.desktop which >> is a decent-sized chunk.: 324 files. I recommend looking at the >> jdk.patch file > > What about src/java.datatransfer module?(it was extracted from desktop) > >> >> I have checked the changes myself visually but also used JPRT to >> make sure that no introduced syntax error causes a build failure. >> >> Separately 2 minor changes to closed source files have been sent for >> internal review. >> >> -phil. > > > -- > Best regards, Sergey. From Sergey.Bylokhov at oracle.com Sat Sep 19 20:14:09 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Sat, 19 Sep 2015 23:14:09 +0300 Subject: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop In-Reply-To: References: <55FC8418.7060603@oracle.com> <55FDB108.80504@oracle.com> Message-ID: <55FDC211.3040909@oracle.com> Looks fine. Thanks! On 19.09.15 22:39, Phil Race wrote: > Let me do that as separate review. There are also demos and tests do this is not the last of it anyway but this is a big one to get out of the way > > -Phil. > >> On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov wrote: >> >> Hi, Phil. >>> >>> >>> What I am updating here is all the files under src/java.desktop which >>> is a decent-sized chunk.: 324 files. I recommend looking at the >>> jdk.patch file >> >> What about src/java.datatransfer module?(it was extracted from desktop) >> >>> >>> I have checked the changes myself visually but also used JPRT to >>> make sure that no introduced syntax error causes a build failure. >>> >>> Separately 2 minor changes to closed source files have been sent for >>> internal review. >>> >>> -phil. >> >> >> -- >> Best regards, Sergey. -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Mon Sep 21 08:31:48 2015 From: alexandr.scherbatiy at oracle.com (Alexandr Scherbatiy) Date: Mon, 21 Sep 2015 11:31:48 +0300 Subject: [OpenJDK 2D-Dev] RFR: 8136783: Run blessed-modifier-order script on java.desktop In-Reply-To: <55FDC211.3040909@oracle.com> References: <55FC8418.7060603@oracle.com> <55FDB108.80504@oracle.com> <55FDC211.3040909@oracle.com> Message-ID: <55FFC074.2030203@oracle.com> The fix looks good to me. Thanks, Alexandr. 19.09.2015 23:14, Sergey Bylokhov ?????: > Looks fine. Thanks! > > On 19.09.15 22:39, Phil Race wrote: >> Let me do that as separate review. There are also demos and tests do >> this is not the last of it anyway but this is a big one to get out of >> the way >> >> -Phil. >> >>> On Sep 19, 2015, at 12:01 PM, Sergey Bylokhov >>> wrote: >>> >>> Hi, Phil. >>>> >>>> >>>> What I am updating here is all the files under src/java.desktop which >>>> is a decent-sized chunk.: 324 files. I recommend looking at the >>>> jdk.patch file >>> >>> What about src/java.datatransfer module?(it was extracted from desktop) >>> >>>> >>>> I have checked the changes myself visually but also used JPRT to >>>> make sure that no introduced syntax error causes a build failure. >>>> >>>> Separately 2 minor changes to closed source files have been sent for >>>> internal review. >>>> >>>> -phil. >>> >>> >>> -- >>> Best regards, Sergey. > > From prasanta.sadhukhan at oracle.com Mon Sep 21 09:27:30 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Mon, 21 Sep 2015 14:57:30 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free Message-ID: <55FFCD82.6070303@oracle.com> Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ Please review a bug fix whereby freeing a FT_StreamRec pointer leads to a crash. It was found that FT_Done_Face() frees the FT_StreamRec pointer if FT allocated memory for it internally. Since Java uses freetype, FT ends up allocating FT_StreamRec structure in Java's TypeFont1. We call FT_Done_Face(FT_Face) and also free(face->stream) resulting in double free causing crash. The solution is to maintain it's own copy of stream pointer so Java knows when it needs to free the stream pointer and when to leave it to FT. Regards Prasanta From brian.burkhalter at oracle.com Mon Sep 21 18:15:03 2015 From: brian.burkhalter at oracle.com (Brian Burkhalter) Date: Mon, 21 Sep 2015 11:15:03 -0700 Subject: [OpenJDK 2D-Dev] [9] RFR of 5100935: No way to access the 64-bit integer multiplication of 64-bit CPUs efficiently In-Reply-To: <55FDBCC1.8060708@oracle.com> References: <3B559334-8ED3-4BEA-85E9-7AA9CD57AA91@oracle.com> <55FDBCC1.8060708@oracle.com> Message-ID: Hello, Sergey, On Sep 19, 2015, at 12:51 PM, Sergey Bylokhov wrote: > Hello, I have a related question about the adding of methods to the Math class. Some methods **Exact methods were added to the Math class in jdk8, which throws an exceptions in case of overflow. Is it possible to add the similar saturation arithmetic? It would be quite good to realize a full range of these methods, and give the chance to hotspot to use an intrinsic. If there are particular methods of interest and there are no corresponding issues on file, then one or more issues should be filed in the Java Bug System so that we may consider and track them according to the usual process. As there is currently an attempt to address some of the omissions in the Math area, now would be a good time to get these issues on record. So I suggest that the interested parties do just that. I think that one issue containing several method requests would be sufficient if it concerns the same area of code. As to the compiler intrinsics, we are looking into adding a few math-related things here as well. This would be tracked by a separate issue which we would file ourselves. Regards, Brian > This is mostly request from the java2d team: > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2008-December/000954.html > "I currently use an utility-class heavily for the XRender Java2D > backend, which performs saturated casts: > > 1.) return (short) (x > Short.MAX_VALUE ? Short.MAX_VALUE : (x < > Short.MIN_VALUE ? Short.MIN_VALUE : x)); > 2.) return (short) (x > 65535 ? 65535 : (x < 0) ? 0 : x); > > I spent quite some time benchmarking/tuning the > protocol-generation-methods, and a lot of cycles are spent in those > saturated casts, even if the utility methods are static. > E.g. XRenderFillRectangle takes 40 cycles without clamping, but > already 70 cycles with on my core2duo with hotspot-server/jdk 14.0. > Hotspot seems to solve the problem always with conditional jumps, > although well predictable ones. > > Modern processors seem to have support for this kind of operation, in > x86 there's packssdw in MMX/SSE2. > I think something like a saturated cast could be quite useful, there > are already cast-methods in Long/Integer/Short - what do you think > about adding saturated casts to that API? > Those could be instrified to use MMX/SSE2 if available. > > If that would be too specific how hard would it be to add this kind of > optimization to hotspot? > How far does SIMD support in hotspot go (I read some time ago there've > been some optimizations), if SIMD would be supported 4 casts could be > done in a single cycle :) -------------- next part -------------- An HTML attachment was scrubbed... URL: From alexandr.scherbatiy at oracle.com Tue Sep 22 09:33:24 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 22 Sep 2015 12:33:24 +0300 Subject: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support Message-ID: <56012064.2020800@oracle.com> Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8073320 webrev: http://cr.openjdk.java.net/~alexsch/8073320/webrev.00 This is an initial part of the HiDPI Graphics support on Windows for the JEP 263: HiDPI Graphics on Windows and Linux http://openjdk.java.net/jeps/263 - scale factors are added to surface dates - window size, events coordinates and font are scaled on native side - backup buffered image is scaled in SunVolatileImage - AwtRobot MouseMove() and GetRGBPixels() methods are updated - GetDpiForMonitor function is used to query the specified monitor for the horizontal and vertical DPI values. If it is not available ID2D1Factory::GetDesktopDpi method is used instead. - "sun.java2d.uiScale.enabled", "sun.java2d.win.uiScale", "sun.java2d.win.uiScaleX", and "sun.java2d.win.uiScaleY" options are added for the testing purposes. Thanks, Alexandr. From philip.race at oracle.com Wed Sep 23 14:43:08 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 Sep 2015 07:43:08 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8133309: Some unicode characters do not display any more after upgrading to Windows 10 In-Reply-To: <55FC6D59.5030101@oracle.com> References: <55FC6D59.5030101@oracle.com> Message-ID: <5602BA7C.2000303@oracle.com> Any takers ? -phil. On 9/18/15 1:00 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8133309 > http://cr.openjdk.java.net/~prr/8133309/ > > Add Segoe UI Symbol (available on Vista and later) to the fall back > list of fonts > for Windows. > > This gives us some coverage we did not have before - better quality too - > but is particularly needed on Windows 10. > > -phil. From Sergey.Bylokhov at oracle.com Wed Sep 23 15:05:46 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 23 Sep 2015 18:05:46 +0300 Subject: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support In-Reply-To: <56012064.2020800@oracle.com> References: <56012064.2020800@oracle.com> Message-ID: <5602BFCA.7050200@oracle.com> Hi, Alexander. A few comments: - Can you clarify the updated array in BufferedImageGraphicsConfig? Probably some javadoc will be useful? - It it possible to document the new options somewhere? I recall we have description of some of related options. Also I suggest to file an additional issue to make these options crossplatform. On 22.09.15 12:33, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8073320 > webrev: http://cr.openjdk.java.net/~alexsch/8073320/webrev.00 > > This is an initial part of the HiDPI Graphics support on Windows for > the JEP 263: HiDPI Graphics on Windows and Linux > http://openjdk.java.net/jeps/263 > > - scale factors are added to surface dates > - window size, events coordinates and font are scaled on native side > - backup buffered image is scaled in SunVolatileImage > - AwtRobot MouseMove() and GetRGBPixels() methods are updated > - GetDpiForMonitor function is used to query the specified monitor > for the horizontal and vertical DPI values. > If it is not available ID2D1Factory::GetDesktopDpi method is used > instead. > - "sun.java2d.uiScale.enabled", "sun.java2d.win.uiScale", > "sun.java2d.win.uiScaleX", and "sun.java2d.win.uiScaleY" options are > added for the testing purposes. > > Thanks, > Alexandr. > -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Wed Sep 23 15:07:45 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 23 Sep 2015 18:07:45 +0300 Subject: [OpenJDK 2D-Dev] RFR: 8133309: Some unicode characters do not display any more after upgrading to Windows 10 In-Reply-To: <5602BA7C.2000303@oracle.com> References: <55FC6D59.5030101@oracle.com> <5602BA7C.2000303@oracle.com> Message-ID: <5602C041.6050801@oracle.com> Looks fine. On 23.09.15 17:43, Phil Race wrote: > Any takers ? > > -phil. > > On 9/18/15 1:00 PM, Phil Race wrote: >> https://bugs.openjdk.java.net/browse/JDK-8133309 >> http://cr.openjdk.java.net/~prr/8133309/ >> >> Add Segoe UI Symbol (available on Vista and later) to the fall back >> list of fonts >> for Windows. >> >> This gives us some coverage we did not have before - better quality too - >> but is particularly needed on Windows 10. >> >> -phil. > -- Best regards, Sergey. From jennifer.godinez at oracle.com Wed Sep 23 17:25:35 2015 From: jennifer.godinez at oracle.com (Jennifer Godinez) Date: Wed, 23 Sep 2015 10:25:35 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8133309: Some unicode characters do not display any more after upgrading to Windows 10 In-Reply-To: <5602BA7C.2000303@oracle.com> References: <55FC6D59.5030101@oracle.com> <5602BA7C.2000303@oracle.com> Message-ID: <5602E08F.806@oracle.com> Looks good. Don't we need regression test though? - Jennifer On 09/23/2015 07:43 AM, Phil Race wrote: > Any takers ? > > -phil. > > On 9/18/15 1:00 PM, Phil Race wrote: >> https://bugs.openjdk.java.net/browse/JDK-8133309 >> http://cr.openjdk.java.net/~prr/8133309/ >> >> Add Segoe UI Symbol (available on Vista and later) to the fall back >> list of fonts >> for Windows. >> >> This gives us some coverage we did not have before - better quality >> too - >> but is particularly needed on Windows 10. >> >> -phil. > From philip.race at oracle.com Wed Sep 23 18:31:10 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 Sep 2015 11:31:10 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8133309: Some unicode characters do not display any more after upgrading to Windows 10 In-Reply-To: <5602E08F.806@oracle.com> References: <55FC6D59.5030101@oracle.com> <5602BA7C.2000303@oracle.com> <5602E08F.806@oracle.com> Message-ID: <5602EFEE.6090900@oracle.com> I had marked the bug noreg-other as whether these code points are available is not directly under our control. It depends on the installed fonts. The underlying issue is that MS removed a font from the default install and that could happen again with these fonts, unlikely as that may be. But we have the outstanding issue that on Windows 10 you won't get Japanese displayed unless you took extra steps since it was a Japanese font. It may be interesting to come up with a set of (non-regression) tests that identify the coverage we expect on a per-platform basis to detect things like this on new versions of a platform, so we have more time to plan. -phil. On 9/23/2015 10:25 AM, Jennifer Godinez wrote: > Looks good. Don't we need regression test though? > > - Jennifer > On 09/23/2015 07:43 AM, Phil Race wrote: >> Any takers ? >> >> -phil. >> >> On 9/18/15 1:00 PM, Phil Race wrote: >>> https://bugs.openjdk.java.net/browse/JDK-8133309 >>> http://cr.openjdk.java.net/~prr/8133309/ >>> >>> Add Segoe UI Symbol (available on Vista and later) to the fall back >>> list of fonts >>> for Windows. >>> >>> This gives us some coverage we did not have before - better quality >>> too - >>> but is particularly needed on Windows 10. >>> >>> -phil. >> > From philip.race at oracle.com Wed Sep 23 21:18:29 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 Sep 2015 14:18:29 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8137059: Run blessed-modifier-order script on client demos and misc. sources Message-ID: <56031725.8050500@oracle.com> https://bugs.openjdk.java.net/browse/JDK-8137059 http://cr.openjdk.java.net/~prr/8137059/ This is a follow-up to https://bugs.openjdk.java.net/browse/JDK-8136783 This new change cleans up the demos and one additional JDK source file. -phil. From Sergey.Bylokhov at oracle.com Thu Sep 24 02:07:50 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 24 Sep 2015 05:07:50 +0300 Subject: [OpenJDK 2D-Dev] RFR: 8137059: Run blessed-modifier-order script on client demos and misc. sources In-Reply-To: <56031725.8050500@oracle.com> References: <56031725.8050500@oracle.com> Message-ID: <56035AF6.2010106@oracle.com> Looks fine. On 24.09.15 0:18, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8137059 > http://cr.openjdk.java.net/~prr/8137059/ > > This is a follow-up to https://bugs.openjdk.java.net/browse/JDK-8136783 > > This new change cleans up the demos and one additional JDK source file. > > -phil. -- Best regards, Sergey. From jennifer.godinez at oracle.com Thu Sep 24 17:02:37 2015 From: jennifer.godinez at oracle.com (Jennifer Godinez) Date: Thu, 24 Sep 2015 10:02:37 -0700 Subject: [OpenJDK 2D-Dev] RFR: 8137059: Run blessed-modifier-order script on client demos and misc. sources In-Reply-To: <56031725.8050500@oracle.com> References: <56031725.8050500@oracle.com> Message-ID: <56042CAD.6020504@oracle.com> Looks good. Jennifer On 09/23/2015 02:18 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8137059 > http://cr.openjdk.java.net/~prr/8137059/ > > This is a follow-up to https://bugs.openjdk.java.net/browse/JDK-8136783 > > This new change cleans up the demos and one additional JDK source file. > > -phil. From prasanta.sadhukhan at oracle.com Fri Sep 25 05:25:19 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Fri, 25 Sep 2015 10:55:19 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: <55FFCD82.6070303@oracle.com> References: <55FFCD82.6070303@oracle.com> Message-ID: <5604DABF.8000107@oracle.com> Hi All, Can this please be reviewed and approved please? Regards Prasanta On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: > Hi All, > > Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 > Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ > > Please review a bug fix whereby freeing a FT_StreamRec pointer leads > to a crash. > It was found that FT_Done_Face() frees the FT_StreamRec pointer if FT > allocated memory for it internally. > Since Java uses freetype, FT ends up allocating FT_StreamRec structure > in Java's TypeFont1. We call FT_Done_Face(FT_Face) > and also free(face->stream) resulting in double free causing crash. > The solution is to maintain it's own copy of stream pointer so Java > knows when it needs to free the stream pointer and when to > leave it to FT. > > Regards > Prasanta From prasanta.sadhukhan at oracle.com Fri Sep 25 06:51:48 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Fri, 25 Sep 2015 12:21:48 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading Message-ID: <5604EF04.8010707@oracle.com> Hi All, Please review addition of this fixed test in open (moved from closed) Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ The review request for fix in this closed test was raised internally and approved. Regards Prasanta From prasanta.sadhukhan at oracle.com Mon Sep 28 11:25:56 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Mon, 28 Sep 2015 16:55:56 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading In-Reply-To: <5604EF04.8010707@oracle.com> References: <5604EF04.8010707@oracle.com> Message-ID: <560923C4.3080809@oracle.com> Hi Alexander, Can this please be approved and committed please since this is already approved in crucible? Regards Prasanta On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: > Hi All, > > Please review addition of this fixed test in open (moved from closed) > > Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 > webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ > > The review request for fix in this closed test was raised internally > and approved. > > Regards > Prasanta From prasanta.sadhukhan at oracle.com Tue Sep 29 05:25:11 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Tue, 29 Sep 2015 10:55:11 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading In-Reply-To: <560923C4.3080809@oracle.com> References: <5604EF04.8010707@oracle.com> <560923C4.3080809@oracle.com> Message-ID: <560A20B7.7060504@oracle.com> Gentle reminder to approve and commit this change. Regards Prasanta On 9/28/2015 4:55 PM, prasanta sadhukhan wrote: > Hi Alexander, > > Can this please be approved and committed please since this is already > approved in crucible? > > Regards > Prasanta > On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: >> Hi All, >> >> Please review addition of this fixed test in open (moved from closed) >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 >> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ >> >> The review request for fix in this closed test was raised internally >> and approved. >> >> Regards >> Prasanta > From prasanta.sadhukhan at oracle.com Tue Sep 29 05:25:50 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Tue, 29 Sep 2015 10:55:50 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: <5608CDF9.5050608@oracle.com> References: <55FFCD82.6070303@oracle.com> <5604DABF.8000107@oracle.com> <5608CDF9.5050608@oracle.com> Message-ID: <560A20DE.4060907@oracle.com> Gentle reminder to approve and commit this change. Regards Prasanta On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: > Hi Phil,Sergey, > > Could you please approve this fix? > I have followed your comment regarding the test. > > Regards > Prasanta > On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: >> Hi All, >> >> Can this please be reviewed and approved please? >> >> Regards >> Prasanta >> On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: >>> Hi All, >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 >>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ >>> >>> Please review a bug fix whereby freeing a FT_StreamRec pointer leads >>> to a crash. >>> It was found that FT_Done_Face() frees the FT_StreamRec pointer if >>> FT allocated memory for it internally. >>> Since Java uses freetype, FT ends up allocating FT_StreamRec >>> structure in Java's TypeFont1. We call FT_Done_Face(FT_Face) >>> and also free(face->stream) resulting in double free causing crash. >>> The solution is to maintain it's own copy of stream pointer so Java >>> knows when it needs to free the stream pointer and when to >>> leave it to FT. >>> >>> Regards >>> Prasanta >> > From alexandr.scherbatiy at oracle.com Tue Sep 29 13:20:11 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 29 Sep 2015 16:20:11 +0300 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading In-Reply-To: <560A20B7.7060504@oracle.com> References: <5604EF04.8010707@oracle.com> <560923C4.3080809@oracle.com> <560A20B7.7060504@oracle.com> Message-ID: <560A900B.5000003@oracle.com> On 9/29/2015 8:25 AM, prasanta sadhukhan wrote: > Gentle reminder to approve and commit this change. Could you describe which changes were made in the fix? Thanks, Alexandr. > > Regards > Prasanta > On 9/28/2015 4:55 PM, prasanta sadhukhan wrote: >> Hi Alexander, >> >> Can this please be approved and committed please since this is >> already approved in crucible? >> >> Regards >> Prasanta >> On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: >>> Hi All, >>> >>> Please review addition of this fixed test in open (moved from closed) >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 >>> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ >>> >>> The review request for fix in this closed test was raised internally >>> and approved. >>> >>> Regards >>> Prasanta >> > From philip.race at oracle.com Tue Sep 29 22:46:33 2015 From: philip.race at oracle.com (Phil Race) Date: Tue, 29 Sep 2015 15:46:33 -0700 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: <560A20DE.4060907@oracle.com> References: <55FFCD82.6070303@oracle.com> <5604DABF.8000107@oracle.com> <5608CDF9.5050608@oracle.com> <560A20DE.4060907@oracle.com> Message-ID: <560B14C9.7090402@oracle.com> Approved. -phil. On 09/28/2015 10:25 PM, prasanta sadhukhan wrote: > Gentle reminder to approve and commit this change. > > Regards > Prasanta > On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: >> Hi Phil,Sergey, >> >> Could you please approve this fix? >> I have followed your comment regarding the test. >> >> Regards >> Prasanta >> On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: >>> Hi All, >>> >>> Can this please be reviewed and approved please? >>> >>> Regards >>> Prasanta >>> On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: >>>> Hi All, >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 >>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ >>>> >>>> Please review a bug fix whereby freeing a FT_StreamRec pointer >>>> leads to a crash. >>>> It was found that FT_Done_Face() frees the FT_StreamRec pointer if >>>> FT allocated memory for it internally. >>>> Since Java uses freetype, FT ends up allocating FT_StreamRec >>>> structure in Java's TypeFont1. We call FT_Done_Face(FT_Face) >>>> and also free(face->stream) resulting in double free causing crash. >>>> The solution is to maintain it's own copy of stream pointer so Java >>>> knows when it needs to free the stream pointer and when to >>>> leave it to FT. >>>> >>>> Regards >>>> Prasanta >>> >> > From prasanta.sadhukhan at oracle.com Wed Sep 30 05:23:56 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Wed, 30 Sep 2015 10:53:56 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading In-Reply-To: <560A900B.5000003@oracle.com> References: <5604EF04.8010707@oracle.com> <560923C4.3080809@oracle.com> <560A20B7.7060504@oracle.com> <560A900B.5000003@oracle.com> Message-ID: <560B71EC.7030404@oracle.com> Hi Alexandr, It's the same fix that you approved in crucible ie, move the instruction to constructor from applet init() so that "dialog" gets initialised properly. The crash was because dialog was not initialised but dialog.displayMessage() was called. Regards Prasanta On 9/29/2015 6:50 PM, Alexander Scherbatiy wrote: > On 9/29/2015 8:25 AM, prasanta sadhukhan wrote: >> Gentle reminder to approve and commit this change. > > Could you describe which changes were made in the fix? > > Thanks, > Alexandr. >> >> Regards >> Prasanta >> On 9/28/2015 4:55 PM, prasanta sadhukhan wrote: >>> Hi Alexander, >>> >>> Can this please be approved and committed please since this is >>> already approved in crucible? >>> >>> Regards >>> Prasanta >>> On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: >>>> Hi All, >>>> >>>> Please review addition of this fixed test in open (moved from closed) >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 >>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ >>>> >>>> The review request for fix in this closed test was raised >>>> internally and approved. >>>> >>>> Regards >>>> Prasanta >>> >> > From prasanta.sadhukhan at oracle.com Wed Sep 30 05:27:23 2015 From: prasanta.sadhukhan at oracle.com (prasanta sadhukhan) Date: Wed, 30 Sep 2015 10:57:23 +0530 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: <560B14C9.7090402@oracle.com> References: <55FFCD82.6070303@oracle.com> <5604DABF.8000107@oracle.com> <5608CDF9.5050608@oracle.com> <560A20DE.4060907@oracle.com> <560B14C9.7090402@oracle.com> Message-ID: <560B72BB.5050309@oracle.com> Thanks Phil. Hi Sergey, Can I get a +1 for this? Regards Prasanta On 9/30/2015 4:16 AM, Phil Race wrote: > Approved. > > -phil. > > On 09/28/2015 10:25 PM, prasanta sadhukhan wrote: >> Gentle reminder to approve and commit this change. >> >> Regards >> Prasanta >> On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: >>> Hi Phil,Sergey, >>> >>> Could you please approve this fix? >>> I have followed your comment regarding the test. >>> >>> Regards >>> Prasanta >>> On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: >>>> Hi All, >>>> >>>> Can this please be reviewed and approved please? >>>> >>>> Regards >>>> Prasanta >>>> On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: >>>>> Hi All, >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 >>>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ >>>>> >>>>> Please review a bug fix whereby freeing a FT_StreamRec pointer >>>>> leads to a crash. >>>>> It was found that FT_Done_Face() frees the FT_StreamRec pointer if >>>>> FT allocated memory for it internally. >>>>> Since Java uses freetype, FT ends up allocating FT_StreamRec >>>>> structure in Java's TypeFont1. We call FT_Done_Face(FT_Face) >>>>> and also free(face->stream) resulting in double free causing crash. >>>>> The solution is to maintain it's own copy of stream pointer so >>>>> Java knows when it needs to free the stream pointer and when to >>>>> leave it to FT. >>>>> >>>>> Regards >>>>> Prasanta >>>> >>> >> > From alexandr.scherbatiy at oracle.com Wed Sep 30 08:32:22 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 30 Sep 2015 11:32:22 +0300 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading In-Reply-To: <560B71EC.7030404@oracle.com> References: <5604EF04.8010707@oracle.com> <560923C4.3080809@oracle.com> <560A20B7.7060504@oracle.com> <560A900B.5000003@oracle.com> <560B71EC.7030404@oracle.com> Message-ID: <560B9E16.7040907@oracle.com> The fix looks good to me. On 9/30/2015 8:23 AM, prasanta sadhukhan wrote: > Hi Alexandr, > > It's the same fix that you approved in crucible This is the open alias and it is always good to have a history of the fix here as well. Thanks, Alexandr. > ie, move the instruction to constructor from applet init() so that > "dialog" gets initialised properly. The crash was because dialog was > not initialised but dialog.displayMessage() was called. > > Regards > Prasanta > On 9/29/2015 6:50 PM, Alexander Scherbatiy wrote: >> On 9/29/2015 8:25 AM, prasanta sadhukhan wrote: >>> Gentle reminder to approve and commit this change. >> >> Could you describe which changes were made in the fix? >> >> Thanks, >> Alexandr. >>> >>> Regards >>> Prasanta >>> On 9/28/2015 4:55 PM, prasanta sadhukhan wrote: >>>> Hi Alexander, >>>> >>>> Can this please be approved and committed please since this is >>>> already approved in crucible? >>>> >>>> Regards >>>> Prasanta >>>> On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: >>>>> Hi All, >>>>> >>>>> Please review addition of this fixed test in open (moved from closed) >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 >>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ >>>>> >>>>> The review request for fix in this closed test was raised >>>>> internally and approved. >>>>> >>>>> Regards >>>>> Prasanta >>>> >>> >> > From alexander.zvegintsev at oracle.com Wed Sep 30 10:22:20 2015 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Wed, 30 Sep 2015 13:22:20 +0300 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading In-Reply-To: <560B9E16.7040907@oracle.com> References: <5604EF04.8010707@oracle.com> <560923C4.3080809@oracle.com> <560A20B7.7060504@oracle.com> <560A900B.5000003@oracle.com> <560B71EC.7030404@oracle.com> <560B9E16.7040907@oracle.com> Message-ID: <560BB7DC.6030401@oracle.com> The fix looks OK to me. Thanks, Alexander. On 09/30/2015 11:32 AM, Alexander Scherbatiy wrote: > > > The fix looks good to me. > > On 9/30/2015 8:23 AM, prasanta sadhukhan wrote: >> Hi Alexandr, >> >> It's the same fix that you approved in crucible > > This is the open alias and it is always good to have a history of > the fix here as well. > > Thanks, > Alexandr. > >> ie, move the instruction to constructor from applet init() so that >> "dialog" gets initialised properly. The crash was because dialog was >> not initialised but dialog.displayMessage() was called. >> >> Regards >> Prasanta >> On 9/29/2015 6:50 PM, Alexander Scherbatiy wrote: >>> On 9/29/2015 8:25 AM, prasanta sadhukhan wrote: >>>> Gentle reminder to approve and commit this change. >>> >>> Could you describe which changes were made in the fix? >>> >>> Thanks, >>> Alexandr. >>>> >>>> Regards >>>> Prasanta >>>> On 9/28/2015 4:55 PM, prasanta sadhukhan wrote: >>>>> Hi Alexander, >>>>> >>>>> Can this please be approved and committed please since this is >>>>> already approved in crucible? >>>>> >>>>> Regards >>>>> Prasanta >>>>> On 9/25/2015 12:21 PM, prasanta sadhukhan wrote: >>>>>> Hi All, >>>>>> >>>>>> Please review addition of this fixed test in open (moved from >>>>>> closed) >>>>>> >>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076540 >>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/ >>>>>> >>>>>> The review request for fix in this closed test was raised >>>>>> internally and approved. >>>>>> >>>>>> Regards >>>>>> Prasanta >>>>> >>>> >>> >> > From volker.simonis at gmail.com Wed Sep 30 14:42:35 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 30 Sep 2015 16:42:35 +0200 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: <560B72BB.5050309@oracle.com> References: <55FFCD82.6070303@oracle.com> <5604DABF.8000107@oracle.com> <5608CDF9.5050608@oracle.com> <560A20DE.4060907@oracle.com> <560B14C9.7090402@oracle.com> <560B72BB.5050309@oracle.com> Message-ID: Hi Prasanta, the fix looks good, but I'm a little concerned about the test. Shouldn't it be at least be marked as 'manual' and provide some means of querying the font path from the user. Otherwise I'm afraid it will just fail with an array index out of bounds exception if called from jtreg. Alternatively (and for me the preferred solution) you could check in a small Type 1 font along with the test such that it will be possible to always execute it stand-alone. Thank you and best regards, Volker On Wed, Sep 30, 2015 at 7:27 AM, prasanta sadhukhan wrote: > Thanks Phil. > Hi Sergey, Can I get a +1 for this? > > Regards > Prasanta > > On 9/30/2015 4:16 AM, Phil Race wrote: >> >> Approved. >> >> -phil. >> >> On 09/28/2015 10:25 PM, prasanta sadhukhan wrote: >>> >>> Gentle reminder to approve and commit this change. >>> >>> Regards >>> Prasanta >>> On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: >>>> >>>> Hi Phil,Sergey, >>>> >>>> Could you please approve this fix? >>>> I have followed your comment regarding the test. >>>> >>>> Regards >>>> Prasanta >>>> On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: >>>>> >>>>> Hi All, >>>>> >>>>> Can this please be reviewed and approved please? >>>>> >>>>> Regards >>>>> Prasanta >>>>> On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: >>>>>> >>>>>> Hi All, >>>>>> >>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 >>>>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ >>>>>> >>>>>> Please review a bug fix whereby freeing a FT_StreamRec pointer leads >>>>>> to a crash. >>>>>> It was found that FT_Done_Face() frees the FT_StreamRec pointer if FT >>>>>> allocated memory for it internally. >>>>>> Since Java uses freetype, FT ends up allocating FT_StreamRec structure >>>>>> in Java's TypeFont1. We call FT_Done_Face(FT_Face) >>>>>> and also free(face->stream) resulting in double free causing crash. >>>>>> The solution is to maintain it's own copy of stream pointer so Java >>>>>> knows when it needs to free the stream pointer and when to >>>>>> leave it to FT. >>>>>> >>>>>> Regards >>>>>> Prasanta >>>>> >>>>> >>>> >>> >> > From philip.race at oracle.com Wed Sep 30 16:03:11 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 30 Sep 2015 09:03:11 -0700 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: References: <55FFCD82.6070303@oracle.com> <5604DABF.8000107@oracle.com> <5608CDF9.5050608@oracle.com> <560A20DE.4060907@oracle.com> <560B14C9.7090402@oracle.com> <560B72BB.5050309@oracle.com> Message-ID: <560C07BF.5060107@oracle.com> Hello Volker, The test lacks an @test tag on purpose so jtreg won't even try to run it. Thus it is a manual test already - you would have to run it yourself outside jtreg. It is 'better than nothing' but admittedly not by much, and having to use internal APIs is not great either. The problem with checking in a font is that the only way we can do this is by creating one ourselves. 3rd party fonts, no matter how permissive the license, can't be checked in without lots of legal work that is out of all proportion to the benefit and would take months to complete even if we could convince someone it was worth it. If someone wants to create such a font - from scratch - not derived from any other work, and contribute under OCA that would be a solution. -phil. On 09/30/2015 07:42 AM, Volker Simonis wrote: > Hi Prasanta, > > the fix looks good, but I'm a little concerned about the test. > > Shouldn't it be at least be marked as 'manual' and provide some means > of querying the font path from the user. > Otherwise I'm afraid it will just fail with an array index out of > bounds exception if called from jtreg. > > Alternatively (and for me the preferred solution) you could check in a > small Type 1 font along with the test such that it will be possible to > always execute it stand-alone. > > Thank you and best regards, > Volker > > > On Wed, Sep 30, 2015 at 7:27 AM, prasanta sadhukhan > wrote: >> Thanks Phil. >> Hi Sergey, Can I get a +1 for this? >> >> Regards >> Prasanta >> >> On 9/30/2015 4:16 AM, Phil Race wrote: >>> Approved. >>> >>> -phil. >>> >>> On 09/28/2015 10:25 PM, prasanta sadhukhan wrote: >>>> Gentle reminder to approve and commit this change. >>>> >>>> Regards >>>> Prasanta >>>> On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: >>>>> Hi Phil,Sergey, >>>>> >>>>> Could you please approve this fix? >>>>> I have followed your comment regarding the test. >>>>> >>>>> Regards >>>>> Prasanta >>>>> On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: >>>>>> Hi All, >>>>>> >>>>>> Can this please be reviewed and approved please? >>>>>> >>>>>> Regards >>>>>> Prasanta >>>>>> On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: >>>>>>> Hi All, >>>>>>> >>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 >>>>>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ >>>>>>> >>>>>>> Please review a bug fix whereby freeing a FT_StreamRec pointer leads >>>>>>> to a crash. >>>>>>> It was found that FT_Done_Face() frees the FT_StreamRec pointer if FT >>>>>>> allocated memory for it internally. >>>>>>> Since Java uses freetype, FT ends up allocating FT_StreamRec structure >>>>>>> in Java's TypeFont1. We call FT_Done_Face(FT_Face) >>>>>>> and also free(face->stream) resulting in double free causing crash. >>>>>>> The solution is to maintain it's own copy of stream pointer so Java >>>>>>> knows when it needs to free the stream pointer and when to >>>>>>> leave it to FT. >>>>>>> >>>>>>> Regards >>>>>>> Prasanta >>>>>> From volker.simonis at gmail.com Wed Sep 30 17:33:46 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 30 Sep 2015 19:33:46 +0200 Subject: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free In-Reply-To: <560C07BF.5060107@oracle.com> References: <55FFCD82.6070303@oracle.com> <5604DABF.8000107@oracle.com> <5608CDF9.5050608@oracle.com> <560A20DE.4060907@oracle.com> <560B14C9.7090402@oracle.com> <560B72BB.5050309@oracle.com> <560C07BF.5060107@oracle.com> Message-ID: On Wed, Sep 30, 2015 at 6:03 PM, Phil Race wrote: > Hello Volker, > > The test lacks an @test tag on purpose so jtreg won't even try to run it. > Ah, I missed that. You're right, thanks for the clarification. > Thus it is a manual test already - you would have to run it yourself outside > jtreg. > It is 'better than nothing' but admittedly not by much, and having > to use internal APIs is not great either. > > The problem with checking in a font is that the only way we can do this > is by creating one ourselves. 3rd party fonts, no matter how permissive > the license, can't be checked in without lots of legal work that is out > of all proportion to the benefit and would take months to complete > even if we could convince someone it was worth it. > I already thought it wouldn't be easy :) Otherwise I'm fine with the change. You can count me as a reviewer if that helps. Regards, Volker > If someone wants to create such a font - from scratch - not derived > from any other work, and contribute under OCA that would be a solution. > > -phil. > > > On 09/30/2015 07:42 AM, Volker Simonis wrote: >> >> Hi Prasanta, >> >> the fix looks good, but I'm a little concerned about the test. >> >> Shouldn't it be at least be marked as 'manual' and provide some means >> of querying the font path from the user. >> Otherwise I'm afraid it will just fail with an array index out of >> bounds exception if called from jtreg. >> >> Alternatively (and for me the preferred solution) you could check in a >> small Type 1 font along with the test such that it will be possible to >> always execute it stand-alone. >> >> Thank you and best regards, >> Volker >> >> >> On Wed, Sep 30, 2015 at 7:27 AM, prasanta sadhukhan >> wrote: >>> >>> Thanks Phil. >>> Hi Sergey, Can I get a +1 for this? >>> >>> Regards >>> Prasanta >>> >>> On 9/30/2015 4:16 AM, Phil Race wrote: >>>> >>>> Approved. >>>> >>>> -phil. >>>> >>>> On 09/28/2015 10:25 PM, prasanta sadhukhan wrote: >>>>> >>>>> Gentle reminder to approve and commit this change. >>>>> >>>>> Regards >>>>> Prasanta >>>>> On 9/28/2015 10:49 AM, prasanta sadhukhan wrote: >>>>>> >>>>>> Hi Phil,Sergey, >>>>>> >>>>>> Could you please approve this fix? >>>>>> I have followed your comment regarding the test. >>>>>> >>>>>> Regards >>>>>> Prasanta >>>>>> On 9/25/2015 10:55 AM, prasanta sadhukhan wrote: >>>>>>> >>>>>>> Hi All, >>>>>>> >>>>>>> Can this please be reviewed and approved please? >>>>>>> >>>>>>> Regards >>>>>>> Prasanta >>>>>>> On 9/21/2015 2:57 PM, prasanta sadhukhan wrote: >>>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132985 >>>>>>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8132985/webrev.00/ >>>>>>>> >>>>>>>> Please review a bug fix whereby freeing a FT_StreamRec pointer leads >>>>>>>> to a crash. >>>>>>>> It was found that FT_Done_Face() frees the FT_StreamRec pointer if >>>>>>>> FT >>>>>>>> allocated memory for it internally. >>>>>>>> Since Java uses freetype, FT ends up allocating FT_StreamRec >>>>>>>> structure >>>>>>>> in Java's TypeFont1. We call FT_Done_Face(FT_Face) >>>>>>>> and also free(face->stream) resulting in double free causing crash. >>>>>>>> The solution is to maintain it's own copy of stream pointer so Java >>>>>>>> knows when it needs to free the stream pointer and when to >>>>>>>> leave it to FT. >>>>>>>> >>>>>>>> Regards >>>>>>>> Prasanta >>>>>>> >>>>>>> >