[OpenJDK 2D-Dev] RFR: [9] JDK-8076540[macosx] NPE due to incorrect threading
Alexander Zvegintsev
alexander.zvegintsev at oracle.com
Wed Sep 30 10:22:20 UTC 2015
The fix looks OK to me.
Thanks,
Alexander.
On 09/30/2015 11:32 AM, Alexander Scherbatiy wrote:
>
>
> The fix looks good to me.
>
> On 9/30/2015 8:23 AM, prasanta sadhukhan wrote:
>> Hi Alexandr,
>>
>> It's the same fix that you approved in crucible
>
> This is the open alias and it is always good to have a history of
> the fix here as well.
>
> Thanks,
> Alexandr.
>
>> ie, move the instruction to constructor from applet init() so that
>> "dialog" gets initialised properly. The crash was because dialog was
>> not initialised but dialog.displayMessage() was called.
>>
>> Regards
>> Prasanta
>> On 9/29/2015 6:50 PM, Alexander Scherbatiy wrote:
>>> On 9/29/2015 8:25 AM, prasanta sadhukhan wrote:
>>>> Gentle reminder to approve and commit this change.
>>>
>>> Could you describe which changes were made in the fix?
>>>
>>> Thanks,
>>> Alexandr.
>>>>
>>>> Regards
>>>> Prasanta
>>>> On 9/28/2015 4:55 PM, prasanta sadhukhan wrote:
>>>>> Hi Alexander,
>>>>>
>>>>> Can this please be approved and committed please since this is
>>>>> already approved in crucible?
>>>>>
>>>>> Regards
>>>>> Prasanta
>>>>> On 9/25/2015 12:21 PM, prasanta sadhukhan wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> Please review addition of this fixed test in open (moved from
>>>>>> closed)
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076540
>>>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8076540/webrev/
>>>>>>
>>>>>> The review request for fix in this closed test was raised
>>>>>> internally and approved.
>>>>>>
>>>>>> Regards
>>>>>> Prasanta
>>>>>
>>>>
>>>
>>
>
More information about the 2d-dev
mailing list