[OpenJDK 2D-Dev] Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method

[Phil Race]

This looks fine although I am unable to work out how a JCK test
detected the duplication

-phil.

On 04/04/2016 08:35 AM, Jayathirth D V wrote:
>
> Hi,
>
> _Please review the following fix in JDK9:_
>
> __
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8153363
>
> Webrev : http://cr.openjdk.java.net/~jdv/8153363/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejdv/8153363/webrev.00/>
>
> Issue : We have redundant check for equality of number of components 
> in PackedColorModel.
>
> Solution : Number of components equality is verified in Parent 
> class(ColorModel) and we call super.equals(), no need for checking the 
> equality again.
>
> JCK test "api/java_awt/Image/PackedColorModel/equalsTests.java" 
> verifies equals() method so added noreg-jck label in bug.
>
> Thanks,
>
> Jay
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160404/19855600/attachment.html>