[OpenJDK 2D-Dev] [9] RFR: JDK-8154057, , [macosx] getPrintJob doesn't throw NPE if Frame is null AND type is COMMON

[Phil Race]

hmm .. if it does not throw NPE when the dialog type is common that 
could mean
that the code is not referencing the frame as a modal parent /owner in 
that case which could
be another bug.
Did you check into how this is used relative to other platforms ?

-phil.


On 04/12/2016 04:16 AM, prasanta sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154057
> webrev: http://cr.openjdk.java.net/~psadhukhan/8154057/webrev.00/
>
> As per spec, Toolkit.getPrintJob() should throw NPE if null frame 
> object is passed to it.
> But on macos, it seems getPrintJob() does not check for null frame and 
> show the print dialog.
>
> Fix is to check for null frame which is same as what we do in windows 
> (WToolkit) and linux (XToolkit).
>
> Regards
> Prasanta