[OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and the printer job name is not passed to the implementing

[Jayathirth D V]

Looks fine.

 

From: prasanta sadhukhan 
Sent: Friday, April 15, 2016 11:18 AM
To: Jayathirth D V; Philip Race
Cc: 2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and the printer job name is not passed to the implementing

 

Thanks Jay.
Please find the new webrev adding @Override annotation and I also changed the copyright to 2016.
http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.01/

Regards
Prasanta

On 4/15/2016 10:09 AM, Jayathirth D V wrote:

Hi Prasanta,

 

Change is working fine, +1.

Additional comments : Please add your analysis in JBS and also remove/update the present Javadoc comment in test case and add Override annotation for subclasses present in test case.

 .

Thanks,

Jay 

 

From: prasanta sadhukhan 
Sent: Thursday, April 14, 2016 7:34 PM
To: Philip Race
Cc: HYPERLINK "mailto:2d-dev at openjdk.java.net"2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6921664, , The amount of copies and the printer job name is not passed to the implementing

 

Hi Jay,

Could you please give your +1 on this?

Regards
Prasanta

On 4/13/2016 9:05 PM, Philip Race wrote:

I have updated the synopsis, please use this in the commit :-
"The number of copies and the job name are not passed to a 3rd party PrintService"

Fix looks fine.

-phil


On 4/4/16, 4:21 AM, prasanta sadhukhan wrote: 

Hi All, 

Please review a fix for jdk9 
Bug: https://bugs.openjdk.java.net/browse/JDK-6921664 
webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/6921664/webrev.00/"http://cr.openjdk.java.net/~psadhukhan/6921664/webrev.00/ 

The issue was 
for a third party non-builtin print service, if the application sets the copies, jobname attribute these attributes are not passed to the third party print() implementation. 
This is because when we find there is a non-builtin print service, we call spoolService() in RasterPrinterJob 
which , even though it creates an attribute set via attributes = new HashPrintRequestAttributeSet(); 
but it does not populate the attributes with the attributes set by the application, so when we call job.print(doc, attributes); we were passing attributes without any attribute set. 

I added the minimal copies and jobName attributes to the attribute list before calling the 3rdparty print implementation. 

Regards 
Prasanta 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160414/52e43852/attachment.html>