[OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

Phil Race philip.race at oracle.com
Wed Apr 20 17:17:39 UTC 2016


Hi,

You removed the following test in CCM.java :

2941         if (obj.getClass() !=  getClass()) {
2942             return false;

2943         }

What this means is that before your change an instance of a subclass of CCM
would never be equals() to any direct instantiatation of CCM but after
your change it can be. I suspect the condition was there on purpose.

-phil.

On 04/20/2016 05:45 AM, Jayathirth D V wrote:
>
> Hi,
>
> _Please review the following fix in JDK9:_
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8153943
>
> This is subtask of https://bugs.openjdk.java.net/browse/JDK-6588409
>
> Webrev : http://cr.openjdk.java.net/~jdv/8153943/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejdv/8153943/webrev.00/>
>
> Issue : Some of the java.awt.image classes are missing either equals() 
> or hashCode() method.
>
> Solution : Add missing equals() or hashCode() methods.
>
> Thanks,
>
> Jay
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160420/994d3bdd/attachment.html>


More information about the 2d-dev mailing list