[OpenJDK 2D-Dev] RFR 8154213: clean up uses of boxed primitive constructors in the java.desktop module

[Phil Race]

On 04/24/2016 10:11 PM, prasanta sadhukhan wrote:
> Hi Phil,
>
> My 2 cents:
> JLayeredPane.java has typo Integer.valueOf.valueOf.

That is a doc typo of course. I can fix that.
> In some cases, you have used
>
> Float.valueOf(xx) like in ServiceDialog.java, PNGImageDecoder.java
>
> but in some cases you jave used
>
> lmObj = lmVal; without using Float.valueOf(). Shouldn't we be 
> consistent to use auto-boxing?

I actually discussed this in my initial email
"in a few cases where we directly assign to a variable use auto-boxing."

So it was deliberate.

-phil.

> Regards Prasanta
>
> On 4/22/2016 11:36 PM, Phil Race wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154213
>> Webrev: http://cr.openjdk.java.net/~prr/8154213/
>>
>> https://bugs.openjdk.java.net/browse/JDK-8145468 has caused
>> the following constructors usages to be deprecated :
>> new Long(long) and new Integer(String)
>> new Integer(int) and new Integer(String)
>> new Float(int) and new Float(String)
>> new Double(int) and new Double(String)
>> new Character(char)
>>
>> The deprecations warnings were suppressed for the java.desktop module.
>>
>> This fix changes all uses in the java.desktop module to use 
>> Foo.valueOf(..)
>> or in a few cases where we directly assign to a variable use 
>> auto-boxing.
>>
>> Additionally doc comments that use constructors were updated.
>>
>> Finally the deprecation suppression was removed.
>>
>> JPRT has been used to verify the build and I have run through the
>> various affected Swing L&Fs using SwingSet as a sanity check.
>>
>> I do not have any information on the performance difference (benefits 
>> or otherwise)
>> of this change but I did not see any usage in java.desktop that 
>> appears to be
>> remotely performance critical.
>>
>> -phil.
>>
>