[OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

[Jayathirth D V]

Hi,

 

Thanks for the review.

Yes we can use it directly in the argument of getServiceProviders() API.

Please find updated webrev for reference:

http://cr.openjdk.java.net/~jdv/8160736/webrev.01/ 

 

I will be pushing the updated change into repo.

 

Regards,

Jay

 

From: Brian Burkhalter 
Sent: Tuesday, August 02, 2016 12:12 AM
To: Phil Race
Cc: 2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8160736 : KSS : unnecessary class.forName in TIFFJPEGCompressor.java

 

+1 for the review with a preference for Vadim's suggestion.

 

Brian

 

On Aug 1, 2016, at 10:15 AM, Phil Race <HYPERLINK "mailto:philip.race at oracle.com"philip.race at oracle.com> wrote:





That would be fine too. The main thing was getting rid of Class.forName

-phil.

On 08/01/2016 10:19 AM, Vadim Pakhnushev wrote:

Why not just registry.getServiceProviders(ImageReaderSpi.class, ?

Vadim

On 01.08.2016 19:13, Jayathirth D V wrote:

Hi,

 

Please review the following fix in JDK9 at your convenience :

 

Bug :https://bugs.openjdk.java.net/browse/JDK-8160736

Webrev :HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8160736/webrev.00/"http://cr.openjdk.java.net/~jdv/8160736/webrev.00/

 

Root Cause : KSS tool has detected usage of class.forName where it can be avoided.

Solution : Use <Classname.class> instead of using class.forName.

 

Thanks,

Jay

 

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160802/23406038/attachment.html>