[OpenJDK 2D-Dev] RFR 8159638: Improve array caches and renderer stats in Marlin renderer

[Philip Race]

I have not yet looked at everything but no issues except that
I find checking in the shell script a bit weird.
Not to mention its technically a "source file" so should have a license.

-phil.

On 8/2/16, 2:56 PM, Jim Graham wrote:
> Thanks Laurent,
>
> On 08/02/2016 05:57 AM, Laurent Bourgès wrote:
>> Thanks for the tip, I made another webrev (for archive) that shows the
>> proper diffs in ArrayCache / ArrayCacheConst:
>> http://cr.openjdk.java.net/~lbourges/marlin/marlin-8159638.1_bis/
>> <http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8159638.1_bis/>
>
> Thanks!
>
>>     In Renderer.java, you create the alphaLine and blkFlags refs as
>>     Clean, but then you always put them back using indices of (0, 0) so
>>     they will never actually be cleaned - is there a reason you don't
>>     just use a dirty ref there?
>>
>> Both alphaLine and blkFlags arrays must be zero-filled as these arrays
>> are storing accumulated values:
>>
>> It is not possible to use a dirty reference in this case as both
>> allocated and returned array may contain garbage data (from the
>> IntArrayCache).
>
> D'oh!  I guess that was obvious.  I wasn't thinking of the fact that 
> dirty caches can initially return a non-zero-filled array - the fact 
> that they clean on "put" is only half of their zero guarantee...
>
>>     Other than that question, I don't see any problems with the fix...
>>
>> Ready to go ?
>> or I need another reviewer, phil ?
>
> Ready from my end.  Phil?
>
>             ...jim
>