[OpenJDK 2D-Dev] RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010

[Philip Race]

We need to ensure it always builds with the "official" compiler of the day,
but at the same time, it should also build with the widest possible array
of compilers. Not just on Windows. So fixes like this are welcome.

-phil.

On 8/4/16, 7:04 AM, Langer, Christoph wrote:
> Thanks Prahalad and Volker.
>
> I pushed: http://hg.openjdk.java.net/jdk9/client/jdk/rev/bf97a92e5de6
>
> And yes, I think JPRT is using higher level compilers - but we at SAP like to be able to also build with older compiler versions, if possible. :)
>
> Best regards
> Christoph
>
>
>> -----Original Message-----
>> From: Prahalad Kumar Narayanan
>> [mailto:prahalad.kumar.narayanan at oracle.com]
>> Sent: Donnerstag, 4. August 2016 14:24
>> To: Langer, Christoph<christoph.langer at sap.com>; 2d-dev at openjdk.java.net
>> Cc: Volker Simonis<volker.simonis at gmail.com>
>> Subject: RE: RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010
>>
>> Hi Christoph
>>
>> The changes are correct. +1
>>
>> Previously, the changes were built with JPRT and it reported successful build.
>> Looks like JPRT system uses latest VS compilers.
>>
>> Thanks
>> Have a good day
>>
>> Prahalad N.
>>
>>
>> From: Langer, Christoph [mailto:christoph.langer at sap.com]
>> Sent: Thursday, August 04, 2016 5:19 PM
>> To: 2d-dev at openjdk.java.net
>> Cc: Volker Simonis; Prahalad Kumar Narayanan
>> Subject: RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010
>>
>> Hi,
>>
>> please review this little fix:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8163177
>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8163177.1/
>>
>> The changes for https://bugs.openjdk.java.net/browse/JDK-8152971 break the
>> build with older Microsoft compilers, e.g. MS Visual Studio 2010 and this can be
>> fixed quite easily.
>>
>> Thanks
>> Christoph