[OpenJDK 2D-Dev] [9] Review Request: JDK-8158524: Test file added for VolatileImage -vs- BufferedImage output comparison
Prasanta Sadhukhan
prasanta.sadhukhan at oracle.com
Thu Aug 11 07:31:35 UTC 2016
You need to use @Override annotation for paint() method. Also, you can
use specific imports rather than package imports.
Also, I guess it's better to throw RuntimeException than Error for
failure, not sure how jtreg will react to it.
Lastly, I am not sure if you can use duke.gif image which maynot be
licensed although we have similar duke.gif in java/awt/print/PrinterJob.
Regards
Prasanta
On 8/11/2016 11:30 AM, Prahalad Kumar Narayanan wrote:
> Hello Everyone
>
> Good day to you.
>
> I 'm planning to add a test file into jdk/test/ repository.
> The webrev changes for the test file is presented herewith.
> Link: http://cr.openjdk.java.net/~pnarayanan/8158524/webrev.00/
>
> Brief on the test & its objectives:
> . As we know, VolatileImage utilizes accelerated rendering using GPU while BufferedImage utilizes software rendering
> . The objective of this test-case is to check whether the rendered 2d primitives appear same on VolatileImage and BufferedImage
> . In rare cases, the rendering on VolatileImage might differ by few pixels from BufferedImage due to D3D/OpenGL driver 's handling of primitives
> . Java2D pipelines for D3D/OpenGL APIs use fudge factors to fine tune rendering calls so that output matches with output of BufferedImage.
> . Thus the test case will help in checking for consistent rendering across pipelines and also in identifying scenarios where pipelines need to be fine-tuned.
>
> Kindly review the test file and share your views at your convenience
>
> Thank you
> Have a good day
>
> Prahalad N.
More information about the 2d-dev
mailing list