[OpenJDK 2D-Dev] RFR: 8145901: Printed content is overlapping.

[Phil Race]

On 08/22/2016 12:31 AM, Prasanta Sadhukhan wrote:
> Printed content is not overlapping after the fix. Looks good to me. +1.
> Dont we need to do the same, applying device scale in
>
> 345     hb_font_set_scale(font,
>  346                      FloatToF26Dot6(jdkFontInfo->ptSize),
>  347                      FloatToF26Dot6(jdkFontInfo->ptSize));

No we don't. It is not applied there which is why there is this line
in HBShaper

  220     if (!aat && (getenv("HB_NODEVTX") != NULL)) {

HB will only use coretext for AAT fonts.

-phil.


>
>
> Regards
> Prasanta
> On 8/12/2016 3:57 AM, Philip Race wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145901
>> Webrev: http://cr.openjdk.java.net/~prr/8145901/
>>
>> As per the evaluation in the bug this is an issue with the
>> device scale being applied to the kerning adjustments made
>> by the layout engine.
>>
>> The fix builds cleanly in JPRT and has been tested with the
>> the JCK test in the bug report.
>> I also did "on-screen" testing of various scripts and did not
>> see any problems.
>>
>> -phil.
>>
>>
>