[OpenJDK 2D-Dev] [9] RFR JDK-8169728: Missing sign checks in TIFFField(TIFFTag tag, int type, int count, Object data) for TIFFTag.TIFF_LONG

[Phil Race]

+1

-phil.

On 12/09/2016 11:18 AM, Brian Burkhalter wrote:
> Forgot to include a link to the updated patch:
>
> http://cr.openjdk.java.net/~bpb/8169728/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8169728/webrev.01/>
>
> Thanks,
>
> Brian
>
> On Dec 8, 2016, at 1:14 PM, Brian Burkhalter 
> <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>
>> The patch has been updated as suggested and the test has been 
>> modified to verify the changes [1]. Note that this patch is with 
>> respect to the repository with the patch for [2] already applied.
>>
>> Thanks,
>>
>> Brian
>>
>> [1] 
>> http://mail.openjdk.java.net/pipermail/2d-dev/2016-December/007993.html
>> [2] https://bugs.openjdk.java.net/browse/JDK-8169725
>>
>> On Dec 7, 2016, at 5:04 PM, Brian Burkhalter 
>> <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>>
>>> No particular reason. I suspect you are correct that it is more 
>>> recognizable so I’ll change it.
>>>
>>> Thanks,
>>>
>>> Brian
>>>
>>> On Dec 7, 2016, at 5:01 PM, Philip Race <philip.race at oracle.com 
>>> <mailto:philip.race at oracle.com>> wrote:
>>>
>>>> One "PS"
>>>> why say4294967295in the spec where 0xFFFFFFFF is probably
>>>> more immediately to most programmers that it is not a random
>>>> choice of number ?
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20161209/bc9cc703/attachment.html>