[OpenJDK 2D-Dev] [9] RFR 8170579: The "Banner page"

[Prahalad Kumar Narayanan]

Hello Prasanta

I believe the 'Banner Page' setting on Print dialog maps to the JobSheets attribute category. 
If this is right, the logic to check support for JobSheets attribute category is correct.

Few corner cases that I observed with BannerTest:
. The test-case does not bail-out when run without any printer installed on Ubuntu.
. Secondly, how do we handle multiple printers installed on the machine
         . The capabilities will vary across printers -> a printer may not support printing BannerPage
         . I believe, the test case should bail-out safely if the particular printer doesn't support BannerPage 

. The logic in other test-case within webrev- TestCheckSystemDefaultBannerOption.java, seems to handle both these conditions

Thanks & Have a good day

Prahalad N.


----------------------------------------------------------------------

Message: 1
Date: Tue, 13 Dec 2016 21:38:26 +0530
From: Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com>
To: Philip Race <philip.race at oracle.com>, 2d-dev
	<2d-dev at openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [9] RFR 8170579: The "Banner page"
	checkbox is disabled
Message-ID: <5227445d-36c7-85a3-9d78-c8061e6e568a at oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed

Gentle reminder for review....

Regards
Prasanta


On 12/7/2016 9:00 PM, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9 where it is seen that "Banner" checkbox 
> in printer dialog is disabled in ubuntu16.10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170579
> webrev: http://cr.openjdk.java.net/~psadhukhan/8170579/webrev.00/
>
> Issue was, in ubuntu16.10 the attribute map does not have 
> "job-sheet-supported" attribute returned by CUPS so this category is 
> not added to supported categories 
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java
> .desktop/unix/classes/sun/print/IPPPrintService.java#l1030]
>
> so isAttributeCategorySupported() called by ServiceDialog returns 
> false 
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java
> .desktop/share/classes/sun/print/ServiceDialog.java#l2763]
> resulting in Banner checkbox getting disabled.
>
> Fix is to check if JobSheet category is supported in underlying 
> platform, only then proceed with the test.
>
> Regards
> Prasanta



------------------------------