[OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range From in print dialog is disabled

[Prahalad Kumar Narayanan]

Note: Sending feedback again with right subject line.

The changes check whether the platform supports PageRanges before starting the test-case.
Looks good.

Thanks & Have a good day

Prahalad N.

Date: Mon, 19 Dec 2016 15:22:55 +0300
From: Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com>
To: Jayathirth D V <jayathirth.d.v at oracle.com>,	Philip Race
	<philip.race at oracle.com>, 2d-dev <2d-dev at openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8170578: The Pages Range
	From in print dialog is disabled
Message-ID: <0c3a214e-0cf6-be93-b838-e7df52f22d6f at oracle.com>
Content-Type: text/plain; charset="utf-8"; Format="flowed"

Modified webrev to avoid NPE when there is no printer installed.

http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.01

Regards
Prasanta


On 12/15/2016 8:50 AM, Prasanta Sadhukhan wrote:
>
> Hi All,
>
> Please review a testbug fix for jdk9 for an issue where it it seen 
> that PageRanges option is disabled in printer dialog in ubuntu16.10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170578
>
> webrev: http://cr.openjdk.java.net/~psadhukhan/8170578/webrev.00/
>
> Issue was, in ubuntu16.10 the attribute map [obtained here 
> http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.
> desktop/unix/classes/sun/print/IPPPrintService.java#l1767]
> does not have
> "pageranges-supported" attribute returned by CUPS so this category is 
> not added to supported categories 
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java
> .desktop/unix/classes/sun/print/IPPPrintService.java#l1030]
> so isAttributeCategorySupported() called by ServiceDialog returns 
> false 
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java
> .desktop/share/classes/sun/print/ServiceDialog.java#l1141]
> resulting in PageRanges option getting disabled.
>
> Fix is to check if PageRanges category is supported in underlying 
> platform, only then proceed with the test.
>
> Regards
> Prasanta