[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8148914: BitDepth.java test fails

[Joseph D. Darcy]

Hi Brian,

On 2/16/2016 9:36 AM, Brian Burkhalter wrote:
> Hi Joe,
>
> On Feb 15, 2016, at 11:15 PM, joe darcy <joe.darcy at oracle.com 
> <mailto:joe.darcy at oracle.com>> wrote:
>
>> On 2/15/2016 1:58 PM, Phil Race wrote:
>>> Assuming it works, this approach seems better.
>>
>> A slightly modified version of Brian's change does the trick.
>>
>> Patch below and updated webrev at
>>
>> http://cr.openjdk.java.net/~darcy/8148914.1/
>
> Picayune remarks (line numbers refer to new version):
>
> 1. Line 121: Would prefer “tiff” to “tif” as the former is the format 
> acronym and consistent with the other array elements.

I'm happy to change "tif" to "tiff" here; I verified the test passes 
under an open-only build as a full Oracle build using "tiff".

> 2. Line 155: So a write failure appends to a log of failures on 
> System.out as opposed to an actual test failure, or am I mistaken?
>

Those are the combinations that need to be accommodated to allow 
open-only Linux build to pass the tests. The relevant messages written 
out in this case are:

....
Testing jpeg writer for type INT_RGB
Testing jpeg writer for type INT_BGR
Testing jpeg writer for type 3BYTE_BGR
Testing jpeg writer for type USHORT_565_RGB
Testing jpeg writer for type USHORT_555_RGB
Testing jpeg writer for type INT_ARGB
     Can't write a type INT_ARGB BufferedImage!
Testing jpeg writer for type INT_ARGB_PRE
     Can't write a type INT_ARGB_PRE BufferedImage!
Testing jpeg writer for type 4BYTE_ABGR
     Can't write a type 4BYTE_ABGR BufferedImage!
Testing jpeg writer for type 4BYTE_ABGR_PRE
     Can't write a type 4BYTE_ABGR_PRE BufferedImage!
...

Phil, any additional comments? I'd like to get some form of this pushed 
to get the test back to green.

HTH and thanks,

-Joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160216/f8a56d6f/attachment.html>