[OpenJDK 2D-Dev] [9] RFR: JDK-8150233, , Missing copyright headers in XSurfaceData/ExtendedKeyCodes

Philip Race philip.race at oracle.com
Mon Feb 22 08:18:15 UTC 2016


I'm surprised that any files were missing the GPL for so long.
I am not sure how you chose 2009 and 2010 as the (C) dates.
The date for these files should be a range based on when they first
were created to last edited. I suspect these are both old ..
And given that typically a script is run to update it to the last date
it was edited, you probably should make the end date 2016 since
it is going to happen anyway. So something like "2002, 2016"

Also add noreg-doc (or something else if you find a better match)

-phil.

On 2/22/16, 11:07 AM, prasanta sadhukhan wrote:
> Hi Phil,
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8150233
> webrev: http://cr.openjdk.java.net/~psadhukhan/8150233/webrev.00/
>
> Missing copyright added to the files.
> I guess 2nd reviewer is not needed for this change.
>
> Regards
> Prasanta



More information about the 2d-dev mailing list