[OpenJDK 2D-Dev] RFR 8148886: SEGV in sun.java2d.marlin.Renderer._endRendering

[Laurent Bourgès]

Phil & Jim,

Thanks for your reviews.

Changeset pushed:
http://hg.openjdk.java.net/jdk9/client/jdk/rev/4f7f1c6d613d

2016-02-23 2:05 GMT+01:00 Philip Race <philip.race at oracle.com>:

> This all looks good to me. Sorry it took a long time to get to it.
>

That's fine.
I wanted to push the SEGV fix as fast as possible but your comments &
suggestions were interesting and improved definitely the proposed solution.

One thing that currently doesn't matter and perhaps never will is
> HardReference perhapscould also over-ride clear() :
>
> public void clear() {
>   super.clear();
>   strongRef = null;
> }
>
> strongRef must no longer be final in this case.
>
> But if anyone ever needs that they can make the change ..
>

That looks interesting but I doubt someone would need to clear such
HardReference (but who knows ?).
(for now I prefer keeping the strongRef field 'final' to let the compiler
perform optimizations)


> So approved.
>
> -phil.
>

Sincerly,
Laurent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160223/44a092c8/attachment.html>