[OpenJDK 2D-Dev] Review request for 8144033 : [TEST_BUG] delays needed in RenderingToCachedGraphicsTest.java

Philip Race philip.race at oracle.com
Tue Jan 5 00:32:40 UTC 2016


That is a good question. Is this intermittent failure specific to D3D ?

Why slower systems ? Is sync not doing its job as advertised and this
shows up more on such systems.

I am sure there are times when we need to put in sleep/wait or similar
for timing sensitive issues but they are inherently unreliable too so
we need to understand why it is necessary.

Also such an evaluation needs to go into the bug report not just the email.

-phil.

On 12/31/15, 4:17 AM, Sergey Bylokhov wrote:
> Hi, Ajit.
> Did you check why Toolkit.getDefaultToolkit().sync(); does not work? 
> Call to sync should be enough to flush gdi,d3d,ogl pipelines(including 
> native state) to make visible on the screen the call fillRect.
>
> On 31/12/15 13:41, Ajit Ghaisas wrote:
>> Hi,
>>
>>        Please review the fix for JDK9.
>>
>>        Webrev: 
>> http://cr.openjdk.java.net/~arapte/ajit/8144033/webrev.00/
>>
>>        Bug: https://bugs.openjdk.java.net/browse/JDK-8144033
>>
>> Issue :
>>
>>        The test fails intermittently on slower systems. It passes on
>> relatively faster systems.
>>
>> Fix :
>>
>> 1.Robot object is created earlier
>>
>> 2.Added delay after fillRect() calls – the method runTest() is executed
>> in AWT-EventQueue processing thread hence, we cannot invoke
>> robot.waitForIdle(). Therefore,  delay() method is used.
>>
>> Regards,
>>
>> Ajit
>>
>
>



More information about the 2d-dev mailing list