[OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for JDK-8144744 : ImageWriter.replacePixels() specification is incorrect regarding null ImageWriteParam

[prasanta sadhukhan]

Looks ok to me and as approved in ccc http://ccc.us.oracle.com/8144744

Regards
Prasanta
On 1/13/2016 3:38 PM, Jayathirth D V wrote:
>
> Hi,
>
> _Please review a simple fix in JDK9:_
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8144744
>
> Webrev : http://cr.openjdk.java.net/~jdv/8144744/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejdv/8144744/webrev.00/>
>
> Issue : Specification of ImageWriter.replacePixels() mentions that 
> Illegal argument exception will be thrown if argument param is null.
>
> Root cause : Implementation of repalcePixels() API is in 
> TIFFImageWriter and we actually use default ImageWriteParam if 
> incoming argument param is null and don’t throw IllegalArgumentException.
>
> Solution : Remove the comment in ‘Throws’ clause of specification 
> which mentions that IllegalArgumentException will be thrown if param 
> is null.
>
> Thanks,
>
> Jay
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160113/b4b38f14/attachment.html>