[OpenJDK 2D-Dev] RFR: 8146881: [TEST] update some imageio plugins tests to affect TIFF format

Alexander Stepanov alexander.v.stepanov at oracle.com
Tue Jan 19 16:17:05 UTC 2016


Hello Sergey,

please find the updated webrev:
http://cr.openjdk.java.net/~avstepan/8146881/webrev.01/index.html

Regards,
Alexander

On 1/18/2016 5:12 PM, Sergey Bylokhov wrote:
> On 15/01/16 15:27, Alexander Stepanov wrote:
>> Hello Sergey,
>>
>>  > Why this test do not cover the gif/bmp as well?
>> I can try to append the test, but it will fail for pair bmp +
>> TYPE_INT_ARGB due to
>> https://bugs.openjdk.java.net/browse/JDK-8147448
>
> So we found a bug in jdk? I guess you can update the test to cover 
> only working set of parameters and add a diff which should be made in 
> the test to catch the problem.
> This is why, I always suggest[1] to validate all supported formats(spi).
>
> [1] 
> http://mail.openjdk.java.net/pipermail/2d-dev/2016-January/006168.html
>
>>
>> Regards,
>> Alexander
>>
>> On 1/12/2016 5:49 PM, Sergey Bylokhov wrote:
>>> Hi, Alexander.
>>> BitDepth.java the @summary should be updated. Why this test do not
>>> cover the gif/bmp as well?
>>> It is unclear why biRGBATypes are unused in the test.
>>>
>>> On 12/01/16 17:40, Alexander Stepanov wrote:
>>>> Please ignore mistaken changes in ImageWriterCompressionTest
>>>> (re-uploading the webrev...)
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>> On 1/12/2016 5:28 PM, Alexander Stepanov wrote:
>>>>> Hello,
>>>>>
>>>>> Some imageio plugins reg. tests should probably be updated to reflect
>>>>> the fact that TIFF format is supported now.
>>>>>
>>>>> Could you please let me know if the following changes are 
>>>>> appropriate?
>>>>> http://cr.openjdk.java.net/~avstepan/8146881/webrev.00/index.html
>>>>> (bug: https://bugs.openjdk.java.net/browse/JDK-8146881)
>>>>>
>>>>> Thanks,
>>>>> Alexander
>>>>
>>>
>>>
>>
>
>




More information about the 2d-dev mailing list