[OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

[Phil Race]

It seems like the expectation was that BASE could be drawn by the old 
imaging path.
which would be lower overhead.
I think we should ask Alexandr what the intention was here and whether the
code that handles the base image needs to be taught how to extract data from
a MultiResolutionImage.

-phil.

On 01/20/2016 08:20 AM, Jayathirth D V wrote:
>
> Hi,
>
> __
>
> _Please review the following fix in JDK9:_
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8147413
>
> Webrev : http://cr.openjdk.java.net/~jdv/8147413/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejdv/8147413/webrev.00/>
>
> Issue : JCK testcase 
> api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] 
> is failing from b96 JDK9 build.
>
> Root cause : In getManager API of SurfaceManager.java we are trying to 
> typecast BaseMultiResolutionImage to BufferedImage and it is causing 
> ClassCastException and in turn IllegalArgumentException seen in result 
> of test case. It is happening because of change made in JDK-8073320 
> <https://bugs.openjdk.java.net/browse/JDK-8073320> in 
> SunGraphics2D.java. In case of VALUE_RESOLUTION_VARIANT_BASE type we 
> are not trying to convert MultiResolutionImage to BufferedImage.
>
> Solution : Modify the condition present in drawHiDPIImage API to 
> convert all MultiResolutionImage to BufferedImage irrespective of 
> KEY_RESOLUTION_VARIANT type.
>
> Thanks,
>
> Jay
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160120/0f9c58e8/attachment.html>