[OpenJDK 2D-Dev] New warnings in layout code
Omair Majid
omajid at redhat.com
Wed Jan 27 20:35:15 UTC 2016
Hi,
* Phil Race <philip.race at oracle.com> [2016-01-21 17:55]:
> On 01/21/2016 01:50 PM, Omair Majid wrote:
> >That said, do you think some sort of add-and-check-for-overflow test
> >would be suitable here? I can take a shot at implementing it, if you
> >like.
>
> Sure ! (to the code change option).
The following webrev implements that:
http://cr.openjdk.java.net/~omajid/webrevs/le-signed-overflow-warnings/00/
It uses comparisons with INT32_MAX and INT32_MIN instead of performing
an addition or subtraction on the variable itself to avoid an overflow.
With this, I no longer get any overflow warnings.
On the other hand, if you think these checks are redundant, then I would
be happy to remove these too.
Thanks,
Omair
--
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the 2d-dev
mailing list