[OpenJDK 2D-Dev] [9] RFR JDK-6591280: getting IPP connection causes disabling jar caches

[Phil Race]

+1

FWIW this being an instance method hides what it does.
It seems like it should have been static but as discussed here it is too 
late for that :-
https://bugs.openjdk.java.net/browse/JDK-4851466

-phil.

On 07/25/2016 02:57 AM, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9 where it is seen that we are 
> unnecessarily disabling jar caching for entire JVM execution
> when a IPPConnection is established, which is wrong.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6591280
> webrev: http://cr.openjdk.java.net/~psadhukhan/6591280/webrev.00/
>
> When IPPService.getIPPConnection(URL url) is called, we call 
> connection.setDefaultUsesCaches(false) [in addition to 
> connection.setUseCaches(false);]
> where "connection" is instance of HttpUrlConnection.
> Calling this setDefaultUsesCaches(false) will result in disabling 
> |URLConnection|'s |useCaches| flag and as spec states "This flag 
> applies to the next, and all following URLConnections that are created"
> so jar caching will be disabled for subsequent URLConnections too.
>
> Proposed fix is to remove this setting of disabling jvm-wide jar caching.
>
> Regards
> Prasanta
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160725/d830a2ee/attachment.html>