[OpenJDK 2D-Dev] (Review request) JDK-8152971: -Xcheck:jni warning

[prasanta sadhukhan]

Please mention for which jdk release you are asking this review for 
like  [9] for jdk9 !!

awt_Component.cpp: Should we continue if there is any exception? You are 
just clearing the exception here, should we also not return as the "obj" 
values are going to be used later on which again will show up other 
problems!!

fontpath.c.
177, 286  this return 1 is not needed

I guess you need to also put noreg-sqe or so in JBS label as it does not 
have testcase and you are using existing JNICheck script.

Regards
Prasanta

On 6/15/2016 10:47 PM, Prahalad Kumar Narayanan wrote:
> Hello Everyone on Java2D group
>
> Good day to you.
>
> Please find herewith, webrev with changes to fix the following issue:
>       Bug ID / Title : JDK-8152971	-Xcheck:jni - WARNING in native method
>       Bug Link  : https://bugs.openjdk.java.net/browse/JDK-8152971
>
> Description on Bug :
>       . Submitter has provided a test code with the bug.
>       . When the test code is run (with -Xcheck:jni in JVM options), JNI warnings are thrown.
>       . The warnings mention that JNI functions invoke Java methods without checking for exceptions.
>
> Description on Changes :
>       . The bug did not appear in Jdk 8 b132 or earlier but is reproducible with 8u91 and 9 versions.
>                 I believe, strict check for conformance has been added recently in JVM that has caused this issue.
>       . In the proposed fix, I 've added JNIEnv->ExceptionCheck and ExceptionClear functions at required places.
>
> Webrev Link:
>       http://cr.openjdk.java.net/~pnarayanan/8152971/webrev.00/
>
> Kindly review the changes at your available time and provide your feedback.
>
> Thanks for your time in review
> Have a good day
>
> Prahalad N
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160616/2b3f0bfd/attachment.html>