[OpenJDK 2D-Dev] Review Request for JDK-6185114: Undefined Exception in SampleModel, method createCompatibleSampleModel
    Ajit Ghaisas 
    ajit.ghaisas at oracle.com
       
    Wed Mar 16 10:27:57 UTC 2016
    
    
  
Hi,
 
Bug : https://bugs.openjdk.java.net/browse/JDK-6185114
 
Issue : Undefined Exception in SampleModel, method createCompatibleSampleModel
 
Root Cause : 
The SampleModel constructor documentation says -  it throws the IllegalArgumentException if the product of width and height parameters is greater than Integer.MAX_VALUE.
The condition for this check is incorrectly checks for "greater than equal to" where it should be only "greater than".
 
Fix :
Corrected the erroneous condition in below webrev and added a test.
http://cr.openjdk.java.net/~arapte/ajit/6185114/webrev.00/
 
Regards,
Ajit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160316/61c383a4/attachment.html>
    
    
More information about the 2d-dev
mailing list