[OpenJDK 2D-Dev] Review Request for JDK-6185114: Undefined Exception in SampleModel, method createCompatibleSampleModel

[Ajit Ghaisas]

Hi,

 

I have corrected the typo and modified the failure message string. 

 

Please review the updated webrev.

http://cr.openjdk.java.net/~arapte/ajit/6185114/webrev.01/

 

Regards,

Ajit   

 

From: prasanta sadhukhan 
Sent: Wednesday, March 16, 2016 4:25 PM
To: Ajit Ghaisas; 2d-dev; Philip Race
Subject: Re: Review Request for JDK-6185114: Undefined Exception in SampleModel, method createCompatibleSampleModel

 

Fix Looks ok. Test failure message does not say what it is failing for. Maybe you can mention "Expected IAE count <>, got IAE count <>" . lune 52 has a typo heiht

Regards
Prasanta

On 3/16/2016 3:57 PM, Ajit Ghaisas wrote:

Hi,

 

Bug : https://bugs.openjdk.java.net/browse/JDK-6185114

 

Issue : Undefined Exception in SampleModel, method createCompatibleSampleModel

 

Root Cause : 

The SampleModel constructor documentation says -  it throws the IllegalArgumentException if the product of width and height parameters is greater than Integer.MAX_VALUE.

The condition for this check is incorrectly checks for "greater than equal to" where it should be only "greater than".

 

Fix :

Corrected the erroneous condition in below webrev and added a test.

HYPERLINK "http://cr.openjdk.java.net/%7Earapte/ajit/6185114/webrev.00/"http://cr.openjdk.java.net/~arapte/ajit/6185114/webrev.00/

 

Regards,

Ajit

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160316/cb564937/attachment.html>