[OpenJDK 2D-Dev] [9] Review Request: 8028486 java/awt/Window/WindowsLeak/WindowsLeak.java fails

[Anton Tarasov]

Ok, good! It passed as I tested it locally.

Anton.

On 5/31/2016 7:05 PM, Sergey Bylokhov wrote:
> On 31.05.16 19:04, Anton Tarasov wrote:
>> Would you mind backporting the fix to jdk8u?
>
> yes, after I prove that the test passed on jdk8u as well.
>
>>
>> Thanks,
>> Anton.
>>
>> On 5/2/2016 11:26 PM, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk9.
>>>
>>> Bug evaluation was done by Anton:
>>> http://mail.openjdk.java.net/pipermail/awt-dev/2016-April/011177.html
>>>
>>> This is a cross-platform bug it affects d3d/ogl pipelines. The problem
>>> is that BufferedContex cached information to skip some native
>>> reconfigurations. But this cache cause a memory leak if some
>>> data(src/dst surfaces) was cached and there was no new rendering in
>>> this context(we create context per-d3d_device/ogl_config).
>>>
>>> In the fix I changed all these caches to weak references. Note that i
>>> use a references as initial values instead of null, just to eliminate
>>> the null checks in the body of the method.
>>>
>>> The test was updated to be more stable(flushed the EDT + flushed the
>>> Disposer thread).
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028486
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8028486/webrev.00
>>>
>>
>
>