[OpenJDK 2D-Dev] [9] RFR 8160888: [PIT] What to expect of updated java/awt/print/PrinterJob/Margins.java

[Phil Race]

80 aset.add(MediaSizeName.ISO_A4);

Why ? You can't require that as not everyone has A4 paper handy.

@requires (os.family == "windows")

You are excluding Mac which you say works fine. Why ? For Linux (or 
maybe all platforms) Isuggest runtime checking to see if the 
margins/printable area correspond to the entire size of the paper and 
treat it with suspicion .. in that case you could skip the actual test - 
like an automatic pass. -phil.

On 07/19/2016 10:33 PM, Prasanta Sadhukhan wrote:
> I have updated the webrev to remove run only on windows jtreg tag as 
> with the fix proposed for
> 6574279: validatePage from PrinterJob returns argument under linux
> the printed margin will be of correct value and not the full 
> imageablearea(0,0,paperwidth,paperheight)
> so the issue will be seen on windows & linux without 6601097 
> <https://bugs.openjdk.java.net/browse/JDK-6601097> fix and not after 
> applying 6601097 <https://bugs.openjdk.java.net/browse/JDK-6601097>. 
> Issue is still not reproducible in mac which prints with correct 
> hardware margin without 6601097 
> <https://bugs.openjdk.java.net/browse/JDK-6601097> fix.
>
> http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.01/
>
> Regards
> Prasanta
> On 7/8/2016 12:59 PM, Prasanta Sadhukhan wrote:
>> Hi All,
>>
>> Please find an updation of the testcase
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160888
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8160888/webrev.00/
>>
>> where the testcase was made automated and
>> specifically pass mediasize=A4 as attributes so that there is no 
>> ambiguity of using "letter" vs "A4".
>> Also, the test is made to run only on windows as the bug is not 
>> reproduced in linux/mac.
>>
>> Regards
>> Prasanta
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20161104/d8bf2e74/attachment.html>