[OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java

[Prasanta Sadhukhan]

On 11/10/2016 9:51 AM, Prahalad Kumar Narayanan wrote:
> Thank you for your time in review Prasanta.
>
> As suggested, I shall add 8166003 to the bug tag before pushing.
>
> Here are my views with regard to usage of JRobot
>          . JRobot extends Robot. In essence, it provides additional functionality on-top of the existing awt Robot.
>          . We could do away with JRobot, by implementing the required JRobot features in the test code
I do not think we need to implement any JRobot features in testcode. I 
guess we alreay have readymade replacements of the methods we are using 
in testcode which are via Robot.mousePress, 
Robot.keyPress(KeyEvent.VK_HOME) so my take was since you are already 
doing away with Util library, why not do away with JRobot from this 
testcase. I am not asking to remove JRobot from our test workspace.
Anyways, it's not mandatory and up to you.

133         ROBOT.mouseMove(p.x, p.y);
  134         ROBOT.clickMouse();
  135         ROBOT.hitKey(KeyEvent.VK_HOME);
  136         ROBOT.waitForIdle();

I am ok with the present changes too.

Regards
Prasanta
>          . Doing so, I see some issues
>                    .  First, we would duplicate the code in multiple places (in JRobot and in test).
>                    .  Suppose, an OS upgrade causes trouble with event handling in future, we should fix both the test-code and the JRobot.
>                    .  Originality of test-code deviates by a good amount.
>          . Since JRobot extends awt Robot, and regTestHelpers library is indeed available in many swing test cases,
>                    . I suggest we retain this implementation in the test without changes.
>                    . The other two helper classes (Util and TestCase) were removed because,
>                              . TestCase is not implemented in regTestHelpers and
>                              . The method Util.blockTillDisplayed has an open issue on JBS
>
> Let me know your thoughts.
>
> Thank you once again for your time in review
> Have a good day
>
> Prahalad N.
>                      
>
> -----Original Message-----
> From: Prasanta Sadhukhan
> Sent: Tuesday, November 08, 2016 10:56 AM
> To: Prahalad Kumar Narayanan; 2d-dev at openjdk.java.net; Philip Race
> Subject: Re: [OpenJDK 2D-Dev] [9] Review Request: [JDK-8166003]: [PIT][TEST_BUG] missing helper for bug6427244.java
>
> I guess you can do away with building JRobot too and just use awt Robot via robot.keyPress, robot.mousePress. Do we then need
>
> @library ../../../regtesthelpers
>
> Additionally, please add 8166003to the bug tag.
>
> Regards
> Prasanta
>
> On 11/8/2016 7:50 AM, Prahalad Kumar Narayanan wrote:
>> Hello Everyone on Java2D Group
>>
>> Request your time in reviewing the fix for the bug- JDK-8166003
>>          Link: https://bugs.openjdk.java.net/browse/JDK-8166003
>>          Title: [PIT][TEST_BUG] missing helper for
>> javax/swing/text/GlyphPainter2/6427244/bug6427244.java
>>
>> Root Cause:
>> The test case requires additional classes in regTestHelpers library. Hence, Jtreg failed with error in compilation.
>>
>> Details on Fix:
>> The dependency on the additional classes has been removed. Test case runs normally.
>>
>> Kindly review the changes at your convenience & provide your
>> suggestions Review Link:
>> http://cr.openjdk.java.net/~pnarayanan/8166003/webrev.00/
>>
>> Thank you for your time in review
>> Have a good day
>>
>> Prahalad N.