[OpenJDK 2D-Dev] [9] RFR JDK-8169725: cannot use TIFFField(TIFFTag tag, int value) for TIFF_LONG values greater than Integer.MAX_VALUE

[Brian Burkhalter]

Hi Jay,

Thanks for investigating this. I add that TIFFImageMetadata.addShortOrLongField() should similarly be changed.

Thanks,

Brian

On Nov 15, 2016, at 10:12 PM, Jayathirth D V <jayathirth.d.v at oracle.com> wrote:

> Present change of having long value as second argument is fine because we support usage of TIFFTag.TIFF_LONG data type in the constructor.
>  
> I was checking for call hierarchy of this particular constructor from within JDK9. Most of the calls to this constructor are using either short or int value for second argument.
>  
> In “public void addShortOrLongField(int tagNumber, int value)“ of TIFFImageMetadata.java also we are calling this constructor. I think we should change addShortOrLongField() signature also to use long value for second argument, because we should support usage of TIFFTag.TIFF_LONG data type from addShortOrLongField().
>  
> Please let me know your inputs.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20161116/baa9d210/attachment.html>