[OpenJDK 2D-Dev] [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

[Sergey Bylokhov]

On 18.11.16 14:33, Prasanta Sadhukhan wrote:
> I guess in this test too
>
> JFrame should be disposed at the end of the test(when the test passed or
> failed)

Correct, good catch.

>
> Regards
> Prasanta
> On 11/18/2016 2:06 PM, Sergey Bylokhov wrote:
>> Looks fine.
>>
>> On 18.11.16 10:32, Prasanta Sadhukhan wrote:
>>> +1
>>>
>>> Regards
>>> Prasanta
>>> On 11/18/2016 12:24 PM, Prahalad Kumar Narayanan wrote:
>>>> Hello Everyone
>>>>
>>>> Good day to you
>>>>
>>>> Request your time in reviewing the fix for an error that I introduced
>>>> in my submission.
>>>>        Bug ID: [JDK-8169879] [TEST_BUG]
>>>> javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation
>>>> failed
>>>>        Relates to: [JDK-8166003] [PIT][TEST_BUG] missing helper for
>>>> javax/swing/text/GlyphPainter2/6427244/bug6427244.java
>>>>
>>>> Root Cause:
>>>> . I had missed to merge one-line of code while raising the webrev for
>>>> JDK-8166003.
>>>> . This caused the compilation error to persist.
>>>> . Kindly excuse for this mistake.
>>>>
>>>> Fix:
>>>> . The correction has been done
>>>> . The change has been verified to work on win7, ubuntu 14, and max
>>>> sierra OS.
>>>>
>>>> . Kindly review the change at your convenience.
>>>>           . Webrev link:
>>>> http://cr.openjdk.java.net/~pnarayanan/8169879/webrev.00/
>>>>
>>>> Thank you for your time in review
>>>> Have a good day
>>>>
>>>> Prahalad N.
>>>
>>
>>
>


-- 
Best regards, Sergey.